generated from element-hq/.github
-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add voice message playback from the timeline #1844
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger Swift against 970769c |
stefanceriu
requested changes
Oct 2, 2023
...ces/Services/Timeline/TimelineItems/Items/Messages/VoiceMessages/VoiceRoomTimelineView.swift
Outdated
Show resolved
Hide resolved
...ces/Services/Timeline/TimelineItems/Items/Messages/VoiceMessages/VoiceRoomTimelineView.swift
Outdated
Show resolved
Hide resolved
...ces/Services/Timeline/TimelineItems/Items/Messages/VoiceMessages/VoiceRoomTimelineView.swift
Outdated
Show resolved
Hide resolved
...ces/Services/Timeline/TimelineItems/Items/Messages/VoiceMessages/VoiceRoomPlaybackView.swift
Outdated
Show resolved
Hide resolved
stefanceriu
approved these changes
Oct 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks and works great, nicely done! 👏👏👏
ElementX/Sources/Services/VoiceMessage/VoiceMessageMediaManager.swift
Outdated
Show resolved
Hide resolved
…der to AudioPlayer
nimau
force-pushed
the
nicolas/voice-messages-timeline-playback
branch
from
October 4, 2023 16:07
163e2df
to
970769c
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to listen to voice messages from a timeline item ( (part of the Voice Messages feature)
Here is a brief explanation of this implementation:
RoomTimelineController
, anAudioPlayer
is attached (if necessary) to the corresponding timeline item via itsAudioPlayerState
AudioPlayer
instantiated, and its state is restored when it is attached.AudioCacheManager
has been implemented, which is currently cleared when theMediaPlayerProvider
instance is deinitialised (.i.e when we exit the room screen). This will probably change when the recording feature is implemented.In order not to affect performance when rendering the timeline, voice messages are not pre-loaded (and no conversion to m4a is performed until we need it).
For a 5-minute voice message, the time taken to convert it the first time is around 1 second.