Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to CalVer like versioning #4187

Merged
merged 2 commits into from
Jan 23, 2025
Merged

Migrate to CalVer like versioning #4187

merged 2 commits into from
Jan 23, 2025

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Jan 23, 2025

Content

In order to simplify the versioning, we are migrating both Element X applications to a CalVer like system.
4 digits for the year, 2 digits for the month and 2 digits for the release number of the month.

This PR update the current value and update the release script.
The release script will update the version during the release and will no more set the next version after the release is done.

Motivation and context

(issue is coming)

Screenshots / GIFs

NA

Tests

  • Start a release and see what is the proposed release version

We will test that everything is fine during the next release

  • Try to upgrade the application using a build with this new system. It should work, i.e. the new versionCode will always be higher that any previous versionCode.

Tested devices

  • Physical
  • Emulator
  • OS version(s):

If you navigate to the settings:

image

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@bmarty bmarty requested a review from a team as a code owner January 23, 2025 10:36
@bmarty bmarty requested review from ganfra and removed request for a team January 23, 2025 10:36
@bmarty bmarty added the PR-Build For changes related to build, tools, CI/CD label Jan 23, 2025
Copy link
Member

@ganfra ganfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thanks!

Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/bsywGp

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.31%. Comparing base (e4768a8) to head (90af825).
Report is 5 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4187   +/-   ##
========================================
  Coverage    83.31%   83.31%           
========================================
  Files         1881     1881           
  Lines        49101    49101           
  Branches      5769     5769           
========================================
  Hits         40910    40910           
  Misses        6116     6116           
  Partials      2075     2075           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmarty bmarty changed the title Migrate to CalVer like verisoning Migrate to CalVer like versioning Jan 23, 2025
@bmarty bmarty merged commit 0b04e40 into develop Jan 23, 2025
30 checks passed
@bmarty bmarty deleted the feature/bma/calver branch January 23, 2025 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Build For changes related to build, tools, CI/CD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants