Code

Media navigation with swipe gesture#4161

Code

Merged

bmarty merged 38 commits intodevelopelement-hq/element-x-android:developfrom feature/bma/mediaNavigationelement-hq/element-x-android:feature/bma/mediaNavigationCopy head branch name to clipboardJan 23, 2025

+2,630-668

Commits

Commits on Jan 22, 2025

• Create MediaGalleryDataSource and extract logic from MediaGalleryPresenter.

  bmarty

  committed
  35cc5df

  Copy full SHA for 35cc5df

• Let MediaGalleryDataSource be an interface

  bmarty

  committed
  cbf7bf0

  Copy full SHA for cbf7bf0

• Remove RetryLoading (use LoadMedia)

  bmarty

  committed
  a06607f

  Copy full SHA for a06607f

• Suppress Detekt false positive (?)

  bmarty

  committed
  32db42a

  Copy full SHA for 32db42a

• Add support for files navigation (when coming from the gallery)

  bmarty

  committed
  7df65b0

  Copy full SHA for 7df65b0

• Open in SingleMedia mode when coming from the timeline

  bmarty

  committed
  ca5c06f

  Copy full SHA for ca5c06f

• If not displayed, make sure to pause the audio / video

  bmarty

  committed
  8d6550b

  Copy full SHA for 8d6550b

• media viewer : create MediaViewerDataSource

  

  ganfra

  authored and

  bmarty

  committed
  98a786b

  Copy full SHA for 98a786b

• Provide duration

  bmarty

  committed
  d26414f

  Copy full SHA for d26414f

• Remove unused import

  bmarty

  committed
  bad4566

  Copy full SHA for bad4566

• media viewer : use collectAsState in the DataSource

  

  ganfra

  authored and

  bmarty

  committed
  3248041

  Copy full SHA for 3248041

• Fix and write tests

  bmarty

  committed
  c0542c8

  Copy full SHA for c0542c8

• Improve loading state and add preview.

  bmarty

  committed
  d6ebec8

  Copy full SHA for d6ebec8

• Add exception for Konsist

  bmarty

  committed
  6c904a4

  Copy full SHA for 6c904a4

• sync strings

  bmarty

  committed
  aa68a35

  Copy full SHA for aa68a35

• Restore caption rendering

  bmarty

  committed
  a4cf1d7

  Copy full SHA for a4cf1d7

• Small cleanup

  bmarty

  committed
  f286f6d

  Copy full SHA for f286f6d

• Add test on SingleMediaGalleryDataSource

  bmarty

  committed
  428b81c

  Copy full SHA for 428b81c

• Add test on MediaViewerDataSource

  bmarty

  committed
  18c3b5b

  Copy full SHA for 18c3b5b

• MediaViewer: add error case in the UI.

  bmarty

  committed
  621558a

  Copy full SHA for 621558a

• Introduce MediaViewerFlickToDismiss and extract to its own file

  bmarty

  committed
  e496bc3

  Copy full SHA for e496bc3

• Restore overlay when user cancel the dragging

  bmarty

  committed
  dfda13a

  Copy full SHA for dfda13a

• Add timestamp to trigger back pagination.

  bmarty

  committed
  bac69c4

  Copy full SHA for bac69c4

• Fix tests.

  bmarty

  committed
  b72f4bb

  Copy full SHA for b72f4bb

• Update screenshots

  

  ElementBot

  authored and

  bmarty

  committed
  74be5a5

  Copy full SHA for 74be5a5

Commits on Jan 23, 2025

• Ensure gallery is paginating to get new items.

  bmarty

  committed
  1580c73

  Copy full SHA for 1580c73

• Fix formatting.

  bmarty

  committed
  77887f9

  Copy full SHA for 77887f9

• Remove useless parameter

  bmarty

  committed
  dff9005

  Copy full SHA for dff9005

• Simplify with code coerceAtLeast(0)`

  bmarty

  committed
  54182b0

  Copy full SHA for 54182b0

• Simplify

  bmarty

  committed
  2fde015

  Copy full SHA for 2fde015

• Add documentation on buildMediaViewerPageList.

  bmarty

  committed
  afd8161

  Copy full SHA for afd8161

• Add name to argument for clarity.

  bmarty

  committed
  a5515b0

  Copy full SHA for a5515b0

• Use Black for code clarity.

  bmarty

  committed
  7dd797b

  Copy full SHA for 7dd797b

• Fix color for media viewer according to Figma.

  bmarty

  committed
  beb835c

  Copy full SHA for beb835c

• Cleanup

  bmarty

  committed
  05660fb

  Copy full SHA for 05660fb

• Improve code clarity

  bmarty

  committed
  4d2edfa

  Copy full SHA for 4d2edfa

• Update screenshots

  ElementBot

  committed
  ba0502c

  Copy full SHA for ba0502c

• Fix pagination restart issue and cover by unit test.

  bmarty

  committed
  da22758

  Copy full SHA for da22758