Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(crypto): verification violation handling and block sending #4126

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

BillCarsonFr
Copy link
Member

@BillCarsonFr BillCarsonFr commented Jan 8, 2025

Draft as it depends on matrix-org/matrix-rust-sdk#4478

Android part of element-hq/element-meta#2492 (still partial as there is no way to verify other users yet on EX, so you can only withdraw the verification requirement).

Content

image

When a previously verified user is not anymore there will now be a banner on top of the composer. The composer will be in a disabled state, as anyhow sending will fail (as per element-hq/element-meta#2488)

Motivation and context

Screenshots / GIFs

Dark:
image
withdraw

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@ElementBot
Copy link
Collaborator

Fails
🚫

Please add a PR- label to categorise the changelog entry.

Generated by 🚫 dangerJS against 27093ef

@BillCarsonFr BillCarsonFr added the PR-Feature For a new feature label Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Feature For a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants