Make Maestro run for each PR push #4121
Open
+3
−17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
Follow up of #4092, since it wasn't working as expected.
workflow_run
configuration for the Maestro job.Motivation and context
Ideally we wanted to run Maestro once the 'Build APK' flow was finished and reuse its output so we don't have to build the APK twice, but this has proven difficult to achieve, since the 2 options GH actions gives us for that are:
workflow_run
, which can set up dependencies in a 'when X flow finishes, run flow Y' way, and it's technically what we want, but has the downside that it'll always use the.yml
contents of thedevelop
branch, which makes it difficult to maintain or change (as proven by Test using Maestro CLI + emulator instead of Cloud #4092 not really working after being merged).workflow_call
, which allows a flow to explicitly start another: it worked as seen in this commit, but ended up in either theMaestro
flow being run and displayed as part of theBuild APK
one or viceversa, and in both cases it was quite awkward since you couldn't see the results directly in the 'checks' UI.So in the end we're just re-building the APK until a better option appears.
Tests
There should be a working 'Maestro (local)' flow in the list of actions run.
Checklist