rust-sdk update: Support persisted WedgeQueueError #3724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillCarsonFr
force-pushed
the
feature/valere/update_send_queue_changes
branch
from
bd5af23 to
3d0ae04
Compare
10 tasks
BillCarsonFr
changed the base branch from
develop
to
feature/valere/bump_rust_sdk_0.2.57
jmartinesp
approved these changes
Oct 24, 2024
| } | ||
| is QueueWedgeError.IdentityViolations -> { | ||
| // smart cast impossible because 'error' is a public API property declared in different module | ||
| LocalEventSendState.Failed.VerifiedUserChangedIdentity((error as QueueWedgeError.IdentityViolations).users.map { UserId(it) }) |
There was a problem hiding this comment.
A way to avoid this seems to be using:
is RustEventSendState.SendingFailed -> error.run {
when (this) {
...
is QueueWedgeError.IdentityViolations -> {
// smart cast impossible because 'error' is a public API property declared in different module
LocalEventSendState.Failed.VerifiedUserChangedIdentity(this.users.map { UserId(it) })
}But I'm not sure if it's worth it.
| LocalEventSendState.Failed.VerifiedUserHasUnsignedDevice( | ||
| // smart cast impossible because 'error' is a public API property declared in different module | ||
| devices = (error as QueueWedgeError.InsecureDevices).userDeviceMap.entries.associate { entry -> | ||
| UserId(entry.key) to entry.value.map { DeviceId(it) } |
There was a problem hiding this comment.
Not a needed change, but for constructors you can also use .map(::DeviceId), which is a bit cleaner.
BillCarsonFr
merged this pull request
into
feature/valere/bump_rust_sdk_0.2.57
13 of 23 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on matrix-org/matrix-rust-sdk#4137
Update breaking changes
Content
Motivation and context
Screenshots / GIFs
Tests
Tested devices
Checklist