-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Voice message scrubbing improvements #1847
Conversation
- Voice messages can be scrubbed (i.e. seeked to) even when they have not been played yet.. - The progress bar is displayed also when paused. - Multiple voice messages can keep their state when paused. - Tries to adhere as much as possible at the detailed "green cursor" behavior in the story (but might not be 100% compliant). Story: element-hq/element-meta#2113
Kudos, SonarCloud Quality Gate passed! |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #1847 +/- ##
===========================================
+ Coverage 63.57% 63.61% +0.04%
===========================================
Files 1313 1313
Lines 34201 34255 +54
Branches 7091 7096 +5
===========================================
+ Hits 21742 21791 +49
- Misses 9217 9219 +2
- Partials 3242 3245 +3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! It's not something that started in this PR, but maybe it would be good to rename MediaPlayer.State
to something like MediaPlayer.SharedState
/ GlobalState
? Or add some docs to it, so we know that's shared for all voice players and the internal one is local to this one.
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
I'd prefer to improve the docs rather than rename stuff otherwise names could get quite lengthy. |
Story: element-hq/element-meta#2113