Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Voice message scrubbing improvements #1847

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

julioromano
Copy link

  • Voice messages can be scrubbed (i.e. seeked to) even when they have not been played yet..
  • The progress bar is displayed also when paused.
  • Multiple voice messages can keep their state when paused.
  • Tries to adhere as much as possible at the detailed "green cursor" behavior in the story (but might not be 100% compliant).

Story: element-hq/element-meta#2113

- Voice messages can be scrubbed (i.e. seeked to) even when they have not been played yet..
- The progress bar is displayed also when paused.
- Multiple voice messages can keep their state when paused.
- Tries to adhere as much as possible at the detailed "green cursor" behavior in the story (but might not be 100% compliant).

Story: element-hq/element-meta#2113
@julioromano julioromano self-assigned this Nov 21, 2023
@julioromano julioromano requested a review from a team as a code owner November 21, 2023 15:05
@julioromano julioromano requested review from jmartinesp and removed request for a team November 21, 2023 15:05
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (92df822) 63.57% compared to head (af35146) 63.61%.
Report is 2 commits behind head on develop.

Files Patch % Lines
...roid/libraries/mediaplayer/impl/MediaPlayerImpl.kt 0.00% 6 Missing ⚠️
.../impl/voicemessages/timeline/VoiceMessagePlayer.kt 95.91% 0 Missing and 2 partials ⚠️
...pl/voicemessages/timeline/VoiceMessagePresenter.kt 86.66% 1 Missing and 1 partial ⚠️
...android/libraries/mediaplayer/impl/SimplePlayer.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1847      +/-   ##
===========================================
+ Coverage    63.57%   63.61%   +0.04%     
===========================================
  Files         1313     1313              
  Lines        34201    34255      +54     
  Branches      7091     7096       +5     
===========================================
+ Hits         21742    21791      +49     
- Misses        9217     9219       +2     
- Partials      3242     3245       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! It's not something that started in this PR, but maybe it would be good to rename MediaPlayer.State to something like MediaPlayer.SharedState / GlobalState? Or add some docs to it, so we know that's shared for all voice players and the internal one is local to this one.

Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/rmCt4a

@julioromano julioromano merged commit de646e4 into develop Nov 21, 2023
16 of 17 checks passed
@julioromano julioromano deleted the julioromano/improve_scrubbing_2 branch November 21, 2023 19:48
@julioromano
Copy link
Author

LGTM, thanks! It's not something that started in this PR, but maybe it would be good to rename MediaPlayer.State to something like MediaPlayer.SharedState / GlobalState? Or add some docs to it, so we know that's shared for all voice players and the internal one is local to this one.

I'd prefer to improve the docs rather than rename stuff otherwise names could get quite lengthy.
I'll be glad to open a doc improvment PR, but so far nothing comes to my mind about what to improve specifically.
Let's talk about it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants