Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delay displaying the voice message download indicator #1793

Merged
merged 2 commits into from
Nov 14, 2023

Conversation

jonnyandrew
Copy link
Contributor

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Only show the voice message downloading indicator after 2 seconds have passed.

Motivation and context

Screenshots / GIFs

Tests

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@jonnyandrew jonnyandrew requested a review from a team as a code owner November 13, 2023 14:36
@jonnyandrew jonnyandrew requested review from jmartinesp and removed request for a team November 13, 2023 14:36
Copy link
Contributor

github-actions bot commented Nov 13, 2023

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/482pY4

jmartinesp
jmartinesp previously approved these changes Nov 13, 2023
Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I ran an action to get the updated screenshots: https://github.com/vector-im/element-x-android/actions/runs/6852632180

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (14be887) 63.40% compared to head (9a6b6ff) 63.40%.
Report is 16 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1793   +/-   ##
========================================
  Coverage    63.40%   63.40%           
========================================
  Files         1292     1292           
  Lines        33568    33588   +20     
  Branches      6981     6987    +6     
========================================
+ Hits         21284    21297   +13     
- Misses        9088     9091    +3     
- Partials      3196     3200    +4     
Files Coverage Δ
...roid/libraries/mediaplayer/impl/MediaPlayerImpl.kt 0.00% <0.00%> (ø)
...timeline/components/event/TimelineItemVoiceView.kt 62.96% <60.00%> (+0.46%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonnyandrew jonnyandrew merged commit 6eb012a into develop Nov 14, 2023
@jonnyandrew jonnyandrew deleted the jonny/vm-delay-downloading-indicator branch November 14, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants