Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add voice message 'hold to record' tooltip #1710

Merged
merged 6 commits into from
Nov 2, 2023
Merged

Conversation

jonnyandrew
Copy link
Contributor

@jonnyandrew jonnyandrew commented Oct 31, 2023

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

  • Add 'hold to record' tooltip for voice message recorder.
  • Add tooltip and tooltip positioning utils to design system library.

Motivation and context

Screenshots / GIFs

Screen_recording_20231031_165833.webm

Tests

  • Tap the record button

Tested devices

  • Physical
  • Emulator
  • OS version(s): 13

Checklist

@jonnyandrew jonnyandrew requested a review from a team as a code owner October 31, 2023 17:20
@jonnyandrew jonnyandrew requested review from julioromano and removed request for a team October 31, 2023 17:20
@jonnyandrew
Copy link
Contributor Author

@callumu I used the stock tooltip component but this didn't allow me to add the arrow shape easily (screen recording in the PR description). Please can you let me know your thoughts?

Copy link
Contributor

github-actions bot commented Oct 31, 2023

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/TJNm5g

@callumu
Copy link

callumu commented Nov 1, 2023

@callumu I used the stock tooltip component but this didn't allow me to add the arrow shape easily (screen recording in the PR description). Please can you let me know your thoughts?

Yep this is okay for now.

Can you ensure the text is body/sm/medium?

@jonnyandrew
Copy link
Contributor Author

Thanks @callumu. I can confirm the font is body/sm/medium (configured here).

Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Attention: 33 lines in your changes are missing coverage. Please review.

Comparison is base (d640b04) 63.47% compared to head (850431a) 63.67%.

❗ Current head 850431a differs from pull request most recent head 6c89588. Consider uploading reports for the commit 6c89588 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1710      +/-   ##
===========================================
+ Coverage    63.47%   63.67%   +0.20%     
===========================================
  Files         1282     1272      -10     
  Lines        33292    32989     -303     
  Branches      6886     6840      -46     
===========================================
- Hits         21131    21006     -125     
+ Misses        8977     8815     -162     
+ Partials      3184     3168      -16     
Files Coverage Δ
...ystem/components/tooltip/ElementTooltipDefaults.kt 80.76% <80.76%> (ø)
...ries/designsystem/components/tooltip/TooltipBox.kt 58.33% <58.33%> (ø)
...es/designsystem/components/tooltip/PlainTooltip.kt 45.45% <45.45%> (ø)
.../libraries/textcomposer/components/RecordButton.kt 48.64% <51.42%> (+9.43%) ⬆️

... and 80 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although a bit flaky, this preview is working in Android Studio:

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have submitted a bug report to Google as I can reproduce this in a small sample: https://issuetracker.google.com/issues/308808808

Perhaps we can leave the broken screenshot here in the hope that it gets fixed upstream at some point.

@jonnyandrew jonnyandrew enabled auto-merge (squash) November 2, 2023 14:00
Copy link

sonarqubecloud bot commented Nov 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jonnyandrew jonnyandrew merged commit 5080df3 into develop Nov 2, 2023
@jonnyandrew jonnyandrew deleted the jonny/vm-tooltip branch November 2, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants