-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add voice message 'hold to record' tooltip #1710
Conversation
@callumu I used the stock tooltip component but this didn't allow me to add the arrow shape easily (screen recording in the PR description). Please can you let me know your thoughts? |
...er/impl/src/main/kotlin/io/element/android/libraries/textcomposer/components/RecordButton.kt
Outdated
Show resolved
Hide resolved
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
7e8d462
to
37bd568
Compare
Yep this is okay for now. Can you ensure the text is body/sm/medium? |
Thanks @callumu. I can confirm the font is body/sm/medium (configured here). |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #1710 +/- ##
===========================================
+ Coverage 63.47% 63.67% +0.20%
===========================================
Files 1282 1272 -10
Lines 33292 32989 -303
Branches 6886 6840 -46
===========================================
- Hits 21131 21006 -125
+ Misses 8977 8815 -162
+ Partials 3184 3168 -16
☔ View full report in Codecov by Sentry. |
e2cbd06
to
850431a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have submitted a bug report to Google as I can reproduce this in a small sample: https://issuetracker.google.com/issues/308808808
Perhaps we can leave the broken screenshot here in the hope that it gets fixed upstream at some point.
...otlin/io/element/android/libraries/designsystem/components/tooltip/ElementTooltipDefaults.kt
Show resolved
Hide resolved
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Type of change
Content
Motivation and context
Screenshots / GIFs
Screen_recording_20231031_165833.webm
Tests
Tested devices
Checklist