Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix identity server settings visibility #29083

Merged
merged 2 commits into from
Jan 24, 2025
Merged

Conversation

dbkr
Copy link
Member

@dbkr dbkr commented Jan 23, 2025

The IS settings got confused with the posthog settings and were only shown if analytics were enabled.

Patch from @t3chguy

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

The IS settings got confused with the posthog settings and were only
shown if analytics were enabled.
@dbkr dbkr marked this pull request as ready for review January 24, 2025 10:07
@dbkr dbkr requested a review from a team as a code owner January 24, 2025 10:07
@dbkr dbkr added this pull request to the merge queue Jan 24, 2025
Merged via the queue into develop with commit 197afd6 Jan 24, 2025
37 checks passed
@dbkr dbkr deleted the dbkr/fix_privacy_posthog branch January 24, 2025 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants