feat(crypto): Support verification violation composer banner #29067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillCarsonFr
added
the
T-Feature
BillCarsonFr
force-pushed
the
valere/verification_violation_banner
branch
from
02a2640 to
8325c0c
Compare
BillCarsonFr
added
T-Task
BillCarsonFr
force-pushed
the
valere/verification_violation_banner
branch
from
dc9ece8 to
f56a743
Compare
BillCarsonFr
requested review from
dbkr,
MidhunSureshR,
florianduros and
uhoreg
and removed request for
MidhunSureshR
dbkr
reviewed
Jan 29, 2025
|
|
||
| export type ViolationType = "PinViolation" | "VerificationViolation"; | ||
|
|
||
| export type ViolationPrompt = { |
There was a problem hiding this comment.
Could all of these exported things have tsdoc please?
| onButtonClick: (ev: ButtonEvent) => void; | ||
| } | ||
|
|
||
| async function mapToViolations(cryptoApi: CryptoApi, members: RoomMember[]): Promise<ViolationPrompt[]> { |
There was a problem hiding this comment.
This could also do with some doc as it's not super obvious what it does.
| }, | ||
| [crypto, room, loadViolations], | ||
| ); | ||
| useTypedEventEmitter(cli, RoomStateEvent.Events, onRoomStateEvent); |
There was a problem hiding this comment.
For functions that are defined and then just used once on the next line, probably may as well just use an anonymous one inline.
| }); | ||
| }, [loadViolations]); | ||
|
|
||
| let onButtonClick: (ev: ButtonEvent) => void = () => {}; |
There was a problem hiding this comment.
It's a bit weird to assign a different callback to the button depending on the state. Generally you would just have one callback which behaves accordingly. Also, you probably want to make it a useCallback and ideally be a bit more specific than onButtonClick (even though in this case there's only one button).
There was a problem hiding this comment.
Thx, I tried that d1509b9
uhoreg
approved these changes
Jan 30, 2025
test/unit-tests/components/views/rooms/UserIdentityWarning-test.tsx
Outdated
Show resolved
Hide resolved
test/unit-tests/components/views/rooms/UserIdentityWarning-test.tsx
Outdated
Show resolved
Hide resolved
test/unit-tests/components/views/rooms/UserIdentityWarning-test.tsx
Outdated
Show resolved
Hide resolved
test/unit-tests/components/views/rooms/UserIdentityWarning-test.tsx
Outdated
Show resolved
Hide resolved
fixup: logger import fixup: test lint type problems fix test having an unexpected verification violation fixup sonarcubes warnings
BillCarsonFr
force-pushed
the
valere/verification_violation_banner
branch
from
c263c81 to
673e0d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft: depends on matrix-org/matrix-js-sdk#4646
Following an initial early review, I have refactored the component to now use a viewModel 8325c0c
The update model has also been made a lot more simple, but also less optimized; as an example a
UserTrustStatusChangedevent will trigger a new computation of all the violations in the room. If we see performances problem this could be improovedFollowing initial review,
Checklist
public/exportedsymbols have accurate TSDoc documentation.