Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Scalability chart widget for website #2124

Merged
merged 0 commits into from
Dec 9, 2024

Conversation

msfstef
Copy link
Contributor

@msfstef msfstef commented Dec 9, 2024

A graph widget for scaling metrics using Chart.js - currently using dummy data for development and iteration.

You can build the website in this branch to check the result, attaching a screenshot for ease of use:

image

@thruflo
Copy link
Contributor

thruflo commented Dec 9, 2024

Looking great, love it.

Some minor feedback:

  • the write workloads are 1 req/s, 8 req/s and 16 req/s. I guess with the middle as the default.
  • capitalisation on the dropdown is inconsistent, suggest using Sync service memory format on the RHS list
  • stick a <figure /> element around the chart in the blog post flow, it'll give it some vspacing
  • drop "coming soon" label from cloud section of benchmarking page
  • ideally do a copy pass on that cloud section i.e.: instead of:

Cloud benchmarks test the performance and scalability of Electric when running behind a CDN.

Maybe:

Electric is designed to run behind a CDN, using the CDN's request collapsing capability to scale out to millions of concurrent users. The graph below shows the latency and compute resource of a single Electric server using this technique to handle millions of concurrent users.

... graph ...

You can see the benchmarking fleet deployed to achieve this test in <garry's folder location>.

@thruflo
Copy link
Contributor

thruflo commented Dec 9, 2024

Also, at least 1m clients! Let's drop in the real data :)

How dynamic are your axis labels? Because the data will vary across metric and workloads.

@thruflo thruflo force-pushed the thruflo/beta-release-post branch from 0fe53ee to fcf22c6 Compare December 9, 2024 14:56
@msfstef
Copy link
Contributor Author

msfstef commented Dec 9, 2024

Also, at least 1m clients! Let's drop in the real data :)

Real data now available - although the graphs are looking very noisy...

How dynamic are your axis labels? Because the data will vary across metric and workloads.

Units are adjusted per metric type, and they all are set to start at 0 on the y-axis and ticks are automatically set. If there's something specific you have in mind do tell!

@msfstef msfstef force-pushed the msfstef/scalability-chart-widget branch from f49c465 to 40d4f28 Compare December 9, 2024 15:04
@msfstef msfstef marked this pull request as ready for review December 9, 2024 15:38
@thruflo thruflo merged commit e32b03f into thruflo/beta-release-post Dec 9, 2024
26 of 27 checks passed
@thruflo thruflo deleted the msfstef/scalability-chart-widget branch December 9, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants