Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore (sync service): improve nimble spec for telemetry span attributes #2095

Merged
merged 2 commits into from
Dec 4, 2024
Merged

chore (sync service): improve nimble spec for telemetry span attributes #2095

merged 2 commits into from
Dec 4, 2024

Conversation

kevin-dp
Copy link
Contributor

@kevin-dp kevin-dp commented Dec 4, 2024

This PR improves the nimble spec for validating span attributes.

icehaunter
icehaunter requested changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@icehaunter icehaunter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nitpick

packages/sync-service/lib/electric/stack_supervisor.ex Outdated Show resolved Hide resolved
@kevin-dp kevin-dp requested a review from icehaunter December 4, 2024 12:16
@kevin-dp kevin-dp merged commit ef90f46 into main Dec 4, 2024
26 checks passed
@kevin-dp kevin-dp deleted the kevin/span-attrs-validation branch December 4, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@icehaunter icehaunter icehaunter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevin-dp @icehaunter