Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

be very fast when parsing the known iso8601 date format #16775

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

be very fast when parsing the known iso8601 date format #16775

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions logstash-core/src/main/java/org/logstash/Timestamp.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,25 @@ public byte[] serialize() {
.withDecimalStyle(DecimalStyle.ofDefaultLocale());

private static Instant tryParse(final String iso8601, final Clock clock, final Locale locale) {
// be very fast when parsing 2024-12-10T11:03:52.571554Z
// we do this for writing to the queue
try {
int year = Integer.parseInt(iso8601.substring(0, 4));
int month = Integer.parseInt(iso8601.substring(5, 7));
int day = Integer.parseInt(iso8601.substring(8, 10));
int hour = Integer.parseInt(iso8601.substring(11, 13));
int minute = Integer.parseInt(iso8601.substring(14, 16));
int second = Integer.parseInt(iso8601.substring(17, 19));
int nano = Integer.parseInt(iso8601.substring(20, 26)) * 1000;

return Instant.ofEpochSecond(
java.time.LocalDateTime.of(year, month, day, hour, minute, second)
.toEpochSecond(java.time.ZoneOffset.UTC),
nano);
} catch (Exception e) {
LOGGER.trace("Failed optimized ISO8601 parsing for input: {}", iso8601, e);
}

final DateTimeFormatter configuredFormatter = LENIENT_ISO_DATE_TIME_FORMATTER.withLocale(locale)
.withDecimalStyle(DecimalStyle.of(locale))
.withZone(clock.getZone());
Expand Down
Loading