Counted keyword synthetic source: inherit source keep mode from index settings #120678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 025063f.
jordan-powers
added
>enhancement
auto-backport
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
lkts
approved these changes
Jan 23, 2025
| assertThat(actual, equalTo(expected)); | ||
| } | ||
|
|
||
| public void testSyntheticSourceInheritsKeepAll() throws IOException { |
There was a problem hiding this comment.
This functionality doesn't exist right?
There was a problem hiding this comment.
Right, it's actually just testing that the object mapper is capturing the source. If you want, I can remove the test.
There was a problem hiding this comment.
Such test should exist elsewhere i would remove it.
|
|
||
| --- | ||
|
|
||
| "synthetic_source_keep value is respected": |
There was a problem hiding this comment.
Do we test nested arrays anywhere?
There was a problem hiding this comment.
It's tested in MapperTestCase::testSyntheticSourceKeepArrays, but I'll add a few cases to the yamlRestTest too.
…erit-index-keep-source
…erit-index-keep-source
This was referenced Jan 23, 2025
|
Backport PR for 8.x opened, #120871 |
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 27, 2025
… (#120871) This patch adds a property to CountedKeywordMapper to track the synthetic_source_keep index setting. This property is then used to properly implement synthetic source support in the counted_keyword field type, with fallback to the ignore_source mechanism when synthetic_source_keep is set in either the field mapping or the index settings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a mechanism to track the value of the
synthetic_source_keepsetting if it is set in the index settings. This value is then used to properly implement synthetic source support in thecounted_keywordfield type.This PR also adds tests to verify that if
synthetic_source_keepis set in the index settings, it is respected by theCountedKeywordFieldMapper.Unlike #120426, this implementation does not inherit
synthetic_source_keepfrom ancestor object nodes.Follow-up to #120078
Relates to #109796