-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Inference API] Add node-local rate limiting for the inference API #120400
Merged
demjened
merged 72 commits into
elastic:main
from
timgrein:inference-api-adaptive-rate-limiting
Jan 29, 2025
Merged
Changes from 71 commits
Commits
Show all changes
72 commits
Select commit
Hold shift + click to select a range
e441ea8
Add node-local rate limiting for the inference API
timgrein 75ee9f4
Merge branch 'main' into inference-api-adaptive-rate-limiting
timgrein 73eb9d5
Fix integration tests by using new LocalStateInferencePlugin instead …
timgrein 6126047
Correct feature flag name
timgrein 091a276
Add more docs, reorganize methods and make some methods package private
timgrein 0a849b9
Merge branch 'main' into inference-api-adaptive-rate-limiting
timgrein bbf5c0c
Clarify comment in BaseInferenceActionRequest
timgrein 01647b6
Fix wrong merge
timgrein e1d017f
Fix checkstyle
timgrein e5b8768
Fix checkstyle in tests
timgrein bae9487
Check that the service we want to the read the rate limit config for …
timgrein e5b8adf
[CI] Auto commit changes from spotless
elasticsearchmachine dc4a79b
Merge branch 'main' into inference-api-adaptive-rate-limiting
timgrein 873d605
checkStyle apply
timgrein 6fe7638
Update docs/changelog/120400.yaml
timgrein 1f3ca4e
Merge branch 'main' into inference-api-adaptive-rate-limiting
timgrein 74909f5
Merge branch 'main' into inference-api-adaptive-rate-limiting
timgrein be9c559
Move rate limit division logic to RequestExecutorService
timgrein 858ca0e
Merge remote-tracking branch 'origin/inference-api-adaptive-rate-limi…
timgrein 15fbb9f
Spotless apply
timgrein c0598ea
Remove debug sout
timgrein e6a0786
Adding a few suggestions
jonathan-buttner 23a6785
Adam feedback
jonathan-buttner cd5686b
Merge pull request #1 from jonathan-buttner/jon-suggested-changes
timgrein 04cf4eb
Merge branch 'main' into inference-api-adaptive-rate-limiting
timgrein 9837304
Fix compilation error
timgrein fa45864
Merge branch 'main' into inference-api-adaptive-rate-limiting
timgrein 3f88940
[CI] Auto commit changes from spotless
elasticsearchmachine a59c8df
Add BWC test case to InferenceActionRequestTests
timgrein b5aacec
Merge remote-tracking branch 'origin/inference-api-adaptive-rate-limi…
timgrein 5d20011
Add BWC test case to UnifiedCompletionActionRequestTests
timgrein f265d52
Update x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/…
timgrein 05745d3
Update x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/…
timgrein 9a13041
Remove addressed TODO
timgrein 5792e38
Merge remote-tracking branch 'origin/inference-api-adaptive-rate-limi…
timgrein 90c20a2
Spotless apply
timgrein a869907
Only use new rate limit specific feature flag
timgrein 8826038
Use ThreadLocalRandom
timgrein dccd816
[CI] Auto commit changes from spotless
elasticsearchmachine 9387604
Use Randomness.get()
timgrein 0594d6b
Merge remote-tracking branch 'origin/inference-api-adaptive-rate-limi…
timgrein 7a83f60
[CI] Auto commit changes from spotless
elasticsearchmachine e5e6471
Fix import
timgrein 850d3a8
Merge remote-tracking branch 'origin/inference-api-adaptive-rate-limi…
timgrein 3d010a4
Use ConcurrentHashMap in InferenceServiceNodeLocalRateLimitCalculator
timgrein 47244bd
Merge branch 'main' into inference-api-adaptive-rate-limiting
timgrein ea7ef83
Check for null value in getRateLimitAssignment and remove AtomicRefer…
timgrein 920c5e0
Merge remote-tracking branch 'origin/inference-api-adaptive-rate-limi…
timgrein 81913e2
Remove newAssignments
timgrein 43b60e7
Up the default rate limit for completions
timgrein 86531fd
Merge branch 'main' into inference-api-adaptive-rate-limiting
timgrein 86db7a9
Merge branch 'main' into inference-api-adaptive-rate-limiting
timgrein d7acd02
Merge branch 'main' into inference-api-adaptive-rate-limiting
timgrein 1f54382
Merge branch 'main' into inference-api-adaptive-rate-limiting
timgrein e8df11a
Merge branch 'main' into inference-api-adaptive-rate-limiting
timgrein 9dc7c10
Merge branch 'main' into inference-api-adaptive-rate-limiting
timgrein 71ae899
Merge branch 'main' into inference-api-adaptive-rate-limiting
timgrein 5912c19
Merge branch 'main' into inference-api-adaptive-rate-limiting
timgrein 67ecf1e
Merge branch 'main' into inference-api-adaptive-rate-limiting
timgrein d9f209a
Merge branch 'main' into inference-api-adaptive-rate-limiting
timgrein 3906cb3
Merge branch 'main' into inference-api-adaptive-rate-limiting
timgrein 40a6198
Put deprecated feature flag back in
timgrein c2a5391
Merge remote-tracking branch 'origin/inference-api-adaptive-rate-limi…
timgrein 5052026
Merge branch 'main' into inference-api-adaptive-rate-limiting
timgrein f856552
Check feature flag in BaseTransportInferenceAction
timgrein e9a7cae
Merge remote-tracking branch 'origin/inference-api-adaptive-rate-limi…
timgrein 57f28db
spotlessApply
timgrein aa33350
Export inference.common
timgrein 059fc24
Do not export inference.common
timgrein 2e0be6f
Provide noop rate limit calculator, if feature flag is disabled
timgrein 2143652
Add proper dependency injection
timgrein 4327df2
Merge branch 'main' into inference-api-adaptive-rate-limiting
timgrein File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
pr: 120400 | ||
summary: "[Inference API] Add node-local rate limiting for the inference API" | ||
area: Machine Learning | ||
type: feature | ||
issues: [] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to to clarify that there is no rerouting in this case.