Revert primary permits changes and add hook #120398
Conversation
kingherc
added
>non-issue
:Distributed Indexing/Engine
elasticsearchmachine
added
the
serverless-linked
kingherc
force-pushed
the
non-issue/ES-10537-hollow-permits
branch
from
af0481e to
bcd04fc
Compare
We would like to avoid using directly primary permits for hollow shards. So we revert relevant changes, and add a hook into the function that gets a primary permit with the purpose of a plugin being able to extend the behavior. Relates ES-10537
kingherc
force-pushed
the
non-issue/ES-10537-hollow-permits
branch
from
bcd04fc to
275f5c0
Compare
|
Pinging @elastic/es-distributed-indexing (Team:Distributed Indexing) |
| ); | ||
|
|
||
| ActionListener<Releasable> onPermitAcquiredWrapped = onPermitAcquired.delegateFailureAndWrap((delegate, releasable) -> { | ||
| final ActionListener<Releasable> wrappedListener = indexShardOperationPermits.wrapContextPreservingActionListener( |
There was a problem hiding this comment.
do we need to do the context preserving in all cases? I don't think so? i.e. during normal operations
There was a problem hiding this comment.
@fcofdez I'm not familiar with what operations need the context. I saw it in IndexShardOperationPermits.java and assumed it's needed here as well.
Note that before this PR, the IndexShardOperationPermits.java was the one potentially triggering the final listener of the operation. However, with this PR, we potentially add another blocking step in the plugin (the additional RefCountingListener here). So we can't be sure whatever thread finally triggers the RefCountingListener has the context, thus I elected to made sure we preserve the context as well to "replicate" the original behavior of IndexShardOperationPermits.java.
After this explanation, do you believe we can safely skip the context?
server/src/main/java/org/elasticsearch/index/shard/IndexEventListener.java
Show resolved
Hide resolved
We would like to avoid using directly primary permits for hollow shards. So we revert relevant changes, and add a hook into the function that gets a primary permit with the purpose of a plugin being able to extend the behavior.
Relates ES-10537