Update model to return correct model for CHAT_COMPLETION task type #120326
+312
−62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaybcee
added
auto-backport
jonathan-buttner
added
:ml
jonathan-buttner
approved these changes
Jan 16, 2025
|
Pinging @elastic/ml-core (Team:ML) |
|
Hi @jaybcee, I've created a changelog YAML for you. |
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
timgrein
reviewed
Jan 17, 2025
| /** | ||
| * This class uses the unified chat completion method. | ||
| */ | ||
| public class SimpleChatCompletionServiceIntegrationValidator implements ServiceIntegrationValidator { |
There was a problem hiding this comment.
Should we've a test class SimpleChatCompletionServiceIntegrationValidatorTests for this?
There was a problem hiding this comment.
Good idea, let me take care of that 👍
timgrein
approved these changes
Jan 17, 2025
💚 Backport successful
|
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 17, 2025
…120326) (#120404) * Update model to return correct model for CHAT_COMPLETION task type * Update docs/changelog/120326.yaml * Delete docs/changelog/120326.yaml * Fixing chat completion functionality * Fixing tests * naming * Fixing tests * Adding more tests --------- Co-authored-by: Jonathan Buttner <[email protected]> Co-authored-by: Jonathan Buttner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CHAT_COMPLETION was introduced as a new task type, but the corresponding model for the task type was not changed. Changing it.
It's a bug, but it's not released yet and is a recent change.
Relates to: https://github.com/elastic/search-team/issues/8457