[Connector API] Support hard deletes with new URL param in delete endpoint #120200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedrazb
added
>feature
:SearchOrg/Extract&Transform
|
Documentation preview: |
|
Pinging @elastic/search-eng (Team:SearchOrg) |
elasticsearchmachine
added
the
Team:SearchOrg
|
Pinging @elastic/search-extract-and-transform (Team:Search - Extract & Transform) |
|
Hi @jedrazb, I've created a changelog YAML for you. |
...rest/src/yamlRestTest/resources/rest-api-spec/test/entsearch/connector/20_connector_list.yml
Outdated
Show resolved
Hide resolved
…lasticsearch into connector-api-add-hard-deletes
jedrazb
commented
Jan 15, 2025
| @@ -280,9 +280,7 @@ setup: | |||
|
|
|||
| --- | |||
| "List Connectors - Soft deleted connectors / no deleted": | |||
| - requires: | |||
| cluster_features: ["connector_soft_deletes"] | |||
There was a problem hiding this comment.
we actually don't have this feature, I ended up deleting this 90862f2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add
hardURL param toDELETE _connector/{id}endpoint.If:
hard=trueconnector doc is hard-deleted from connector indexhard=false(default) connector doc is marked as deleted with a flag, doc stays in the indexAdded unit tests and yaml e2e tests.
Remove unused wire serialisation code from the delete action, use
localOnly()as the request is always executed on the node receiving the request.