-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support mTLS in Elastic Inference Service plugin (#116423) #119679
Merged
vidok
merged 4 commits into
elastic:main
from
vidok:dmitrii/reintroduce-inference-service-mtls
Jan 15, 2025
Merged
Support mTLS in Elastic Inference Service plugin (#116423) #119679
vidok
merged 4 commits into
elastic:main
from
vidok:dmitrii/reintroduce-inference-service-mtls
Jan 15, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi @vidok, I've created a changelog YAML for you. |
vidok
added
the
auto-backport
Automatically create backport pull requests when merged
label
Jan 10, 2025
Pinging @elastic/ml-core (Team:ML) |
vidok
force-pushed
the
dmitrii/reintroduce-inference-service-mtls
branch
from
January 10, 2025 11:38
616264d
to
df50a54
Compare
slobodanadamovic
approved these changes
Jan 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jonathan-buttner
approved these changes
Jan 10, 2025
* Introduce new SSL settings under `xpack.inference.elastic.http.ssl`. * Support mTLS connection between Elasticsearch and Elastic Inference Service.
vidok
force-pushed
the
dmitrii/reintroduce-inference-service-mtls
branch
from
January 14, 2025 14:28
df50a54
to
d7d9cdf
Compare
maxjakob
reviewed
Jan 14, 2025
x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/InferencePlugin.java
Show resolved
Hide resolved
💔 Backport failed
You can use sqren/backport to manually backport by running |
vidok
added a commit
that referenced
this pull request
Jan 16, 2025
* Support mTLS in Elastic Inference Service plugin (#116423) * Introduce new SSL settings under `xpack.inference.elastic.http.ssl`. * Support mTLS connection between Elasticsearch and Elastic Inference Service. * Update docs/changelog/119679.yaml * Apply new changelog * [CI] Auto commit changes from spotless --------- Co-authored-by: elasticsearchmachine <[email protected]> (cherry picked from commit 03424aa)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
vidok
added a commit
that referenced
this pull request
Jan 17, 2025
* Support mTLS in Elastic Inference Service plugin (#116423) * Introduce new SSL settings under `xpack.inference.elastic.http.ssl`. * Support mTLS connection between Elasticsearch and Elastic Inference Service. * Update docs/changelog/119679.yaml * Apply new changelog * [CI] Auto commit changes from spotless --------- Co-authored-by: elasticsearchmachine <[email protected]> (cherry picked from commit 03424aa)
vidok
added a commit
that referenced
this pull request
Jan 21, 2025
…120306) * Support mTLS in Elastic Inference Service plugin (#116423) * Introduce new SSL settings under `xpack.inference.elastic.http.ssl`. * Support mTLS connection between Elasticsearch and Elastic Inference Service. * Update docs/changelog/119679.yaml * Apply new changelog * [CI] Auto commit changes from spotless --------- Co-authored-by: elasticsearchmachine <[email protected]> (cherry picked from commit 03424aa)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-backport
Automatically create backport pull requests when merged
backport pending
>feature
:ml
Machine learning
Team:ML
Meta label for the ML team
v8.18.0
v9.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Technically, this PR reverts b357936227df04f88c980b6cbf7cd7cde982a25b.
This PR introduced support for mTLS in the Elastic Inference Service plugin. It uses SSLService to parse, validate the configuration, and create an SSLStrategy that’s used in the
HTTPClientManager
.xpack.inference.elastic.http.ssl
to SSLService.HTTPClientManager
to propagateSSLStrategy
toHTTPClientConnectionManager
How to test the PR locally?:
Skip certificates validation
./gradlew localDistro
.build/distribution/local/elasticsearch-x.x.x-SNAPSHOT
folder.Certificates validation
./gradlew localDistro
.build/distribution/local/elasticsearch-x.x.x-SNAPSHOT
folder.tls.key
,tis.crt
andca.crt
to Elasticsearch snapshotconfig
folder.ca.crt
toca.pem
(it seems unnecessary but ES expects a PEM file).Perform inference requests:
Follow-up actions: