Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Doc+) Expand watermark resolution #119174

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

kunisen
Copy link
Contributor

@kunisen kunisen commented Dec 20, 2024

  • Have you signed the contributor license agreement? Yes
  • Have you followed the contributor guidelines? Yes
  • If submitting code, have you built your formula locally prior to submission with gradle check? Not a code PR
  • If submitting code, is your pull request against main? Unless there is a good reason otherwise, we prefer pull requests against main and will backport as needed. Not a code PR
  • If submitting code, have you checked that your submission is for an OS and architecture that we support? Not a code PR
  • If you are submitting this code for a class then read our policy for that. Not a code PR

Description

Relaunch #116892 since the original one seems to be outdated and hard to update branch. It's copying 10fb2b1 without any further contents update.

Thanks @stefnestor for reaching out and sync. As we chatted, since #116892 is outdated and seems hard to update branch (to merge current main branch to the PR), I copied the contents out from original one manually and created this one. Let's keep your style this time (on ES doc).

For the cloud side doc PR how to handle, let's discuss further offline. 🙏

Relaunch #116892 since the original one seems to be outdated and hard to update branch.
@kunisen kunisen added >enhancement >docs General docs changes Team:Docs Meta label for docs team external-contributor Pull request authored by a developer outside the Elasticsearch team v9.0.0 v8.18.0 labels Dec 20, 2024
@kunisen kunisen requested a review from stefnestor December 20, 2024 04:46
Copy link
Contributor

Documentation preview:

@kunisen kunisen requested a review from a team December 20, 2024 04:46
@elasticsearchmachine
Copy link
Collaborator

@kunisen please enable the option "Allow edits and access to secrets by maintainers" on your PR. For more information, see the documentation.

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

Copy link
Contributor

@shainaraskas shainaraskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of notes and a question!

@@ -53,7 +53,7 @@ GET _cluster/allocation/explain
[[fix-watermark-errors-temporary]]
==== Temporary Relief

To immediately restore write operations, you can temporarily increase the
To immediately restore write operations, you may consider temporarily increasing the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's revert this - the original version was closer to our style

Suggested change
To immediately restore write operations, you may consider temporarily increasing the
To immediately restore write operations, you can temporarily increase

Comment on lines +105 to 106
To resolve, we recommend you do one of the following best suited
to your use case:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To resolve, we recommend you do one of the following best suited
to your use case:
To resolve watermark errors permanently, perform one of the following actions:

* add nodes to the affected <<data-tiers,data tiers>>
+
TIP: You should enable <<xpack-autoscaling,autoscaling>> for clusters deployed using our {ess}, {ece}, and {eck} platforms.
* horizontally scale nodes of the affected <<data-tiers,data tiers>>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does "horizontally" mean here?

Suggested change
* horizontally scale nodes of the affected <<data-tiers,data tiers>>
* Horizontally scale nodes of the affected <<data-tiers,data tiers>>.

+
TIP: On {ess}, https://support.elastic.co[Elastic Support] intervention may
become necessary if <<cluster-health,cluster health>> reaches `status:red`.
* vertically scale existing nodes to increase disk space
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto - what does 'vertically' imply?

Suggested change
* vertically scale existing nodes to increase disk space
* Vertically scale existing nodes to increase disk space.


* delete unneeded indices using the <<indices-delete-index,delete index API>>
* delete indices using the <<indices-delete-index,delete index API>>, either
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* delete indices using the <<indices-delete-index,delete index API>>, either
* Delete indices using the <<indices-delete-index,delete index API>>, either

Comment on lines +113 to +114
permanently if unneeded or temporarily to later
<<snapshots-restore-snapshot,snapshot restore>>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
permanently if unneeded or temporarily to later
<<snapshots-restore-snapshot,snapshot restore>>
permanently if the index isn't needed, or temporarily to later
<<snapshots-restore-snapshot,restore>>.

Comment on lines +119 to +125
TIP: On {ess} and {ece}, indices may need to be temporarily deleted via
its {cloud}/ec-api-console.html[Elasticsearch API Console] to later
<<snapshots-restore-snapshot,snapshot restore>> in order to resolve
<<cluster-health,cluster health>> `status:red` which will block
{cloud}/ec-activity-page.html[attempted changes]. If you experience issues
with this resolution flow on {ess}, kindly reach out to
https://support.elastic.co[Elastic Support] for assistance.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we explain why they have to do the deletion here? how does someone determine if this note applies to them?

Comment on lines +127 to +128
To avoid this situation, we recommend you do one of the following best
suited to your use case:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To avoid this situation, we recommend you do one of the following best
suited to your use case:
== Prevent watermark errors
To avoid watermark errors in future, , perform one of the following actions:

Comment on lines +130 to +135
* enable <<xpack-autoscaling,autoscaling>> for clusters deployed using our
{ess}, {ece}, and {eck} platforms

* setup {kibana-ref}/kibana-alerts.html[Stack Monitoring Alerts] on top of
<<monitor-elasticsearch-cluster,{es} Monitoring>> to be notified before
flood-stage watermark is reached
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* enable <<xpack-autoscaling,autoscaling>> for clusters deployed using our
{ess}, {ece}, and {eck} platforms
* setup {kibana-ref}/kibana-alerts.html[Stack Monitoring Alerts] on top of
<<monitor-elasticsearch-cluster,{es} Monitoring>> to be notified before
flood-stage watermark is reached
* If you're using {ess}, {ece}, or {eck}: Enable <<xpack-autoscaling,autoscaling>>.
* Set up {kibana-ref}/kibana-alerts.html[stack monitoring alerts] on top of
<<monitor-elasticsearch-cluster,{es} monitoring>> to be notified before
the flood-stage watermark is reached.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>docs General docs changes >enhancement external-contributor Pull request authored by a developer outside the Elasticsearch team Team:Docs Meta label for docs team v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants