Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing timeouts to rest-api-spec ILM APIs #118837

Merged
merged 6 commits into from
Dec 18, 2024

Conversation

pquentin
Copy link
Member

I have noticed those when reviewing elastic/elasticsearch-specification#3297. I tagged Data Management because those are ILM APIs but also Cluster Coordination as @DaveCTurner worked on those timeouts this year.

@pquentin pquentin added >bug :Distributed Coordination/Cluster Coordination Cluster formation and cluster state publication, including cluster membership and fault detection. :Data Management/ILM+SLM Index and Snapshot lifecycle management auto-backport Automatically create backport pull requests when merged v9.0.0 v8.17.1 v8.16.3 labels Dec 17, 2024
@elasticsearchmachine elasticsearchmachine added Team:Data Management Meta label for data/management team Team:Distributed Coordination Meta label for Distributed Coordination team labels Dec 17, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@elasticsearchmachine
Copy link
Collaborator

Hi @pquentin, I've created a changelog YAML for you.

@DaveCTurner DaveCTurner removed :Distributed Coordination/Cluster Coordination Cluster formation and cluster state publication, including cluster membership and fault detection. Team:Distributed Coordination Meta label for Distributed Coordination team labels Dec 17, 2024
@@ -0,0 +1,5 @@
pr: 118837
summary: Add missing timeouts to rest-api-spec ILM APIs
area: "Cluster Coordination"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me but these omissions pre-date #109112 and definitely belong to ILM rather than Cluster Coordination

Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with David's comment about changing the area in the changelog

@pquentin pquentin merged commit ffe9002 into elastic:main Dec 18, 2024
16 checks passed
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.17
8.16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged >bug :Data Management/ILM+SLM Index and Snapshot lifecycle management Team:Data Management Meta label for data/management team v8.16.3 v8.17.1 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants