Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update match-phrase-query.asciidoc #118828

Merged
merged 3 commits into from
Jan 28, 2025
Merged

Update match-phrase-query.asciidoc #118828

merged 3 commits into from
Jan 28, 2025

Conversation

damien-renier-elastic
Copy link
Contributor

@damien-renier-elastic damien-renier-elastic commented Dec 17, 2024 •
edited by leemthompo
Loading

Added Parameters for consistency

@damien-renier-elastic
Update match-phrase-query.asciidoc
a37669f 
Added Parameters for consistency
@github-actions GitHub Actions
Copy link
Contributor

Documentation preview:

@elasticsearchmachine
Copy link
Collaborator

@damien-renier-elastic please enable the option "Allow edits and access to secrets by maintainers" on your PR. For more information, see the documentation.

@elasticsearchmachine elasticsearchmachine added v8.17.1 needs:triage Requires assignment of a team area label external-contributor Pull request authored by a developer outside the Elasticsearch team labels Dec 17, 2024
@damien-renier-elastic damien-renier-elastic added the >docs General docs changes label Dec 17, 2024
@elasticsearchmachine elasticsearchmachine added Team:Docs Meta label for docs team and removed needs:triage Requires assignment of a team area label labels Dec 17, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@leemthompo
Copy link
Contributor

leemthompo commented Dec 17, 2024 •
edited
Loading

@damien-renier-elastic the changes show you deleted a paragraph about the slop flag, which doesn't seem to reflect your PR description?

@damien-renier-elastic
Copy link
Contributor Author

damien-renier-elastic commented Dec 17, 2024 •
edited
Loading

Removed 2 paragraphes:

  • slop
  • zero_terms_query

Because they are now part of the parameters section

Created the parameters paragraph instead for consistency with other methods.
Added:

  • query
  • analyzer
  • slop
  • zero_terms-query

Added a new header for the Analyzer example

@leemthompo
Copy link
Contributor

@damien-renier-elastic sorry looking at the changed files it still just looks like you only deleted a paragraph about the slop flag

@damien-renier-elastic
Copy link
Contributor Author

My bad, I somehow managed to reset my modifications after the merge. I double-checked this time.

@leemthompo leemthompo added auto-backport Automatically create backport pull requests when merged v8.16.0 v9.0.0 v8.18.0 labels Jan 28, 2025
leemthompo
leemthompo approved these changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@leemthompo leemthompo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@leemthompo leemthompo self-assigned this Jan 28, 2025
@leemthompo leemthompo merged commit 8e9cccb into 8.17 Jan 28, 2025
6 checks passed
@leemthompo leemthompo deleted the damien-renier-elastic-patch-2 branch January 28, 2025 13:30
@leemthompo leemthompo mentioned this pull request Jan 28, 2025
Merged
leemthompo pushed a commit to leemthompo/elasticsearch that referenced this pull request Jan 28, 2025
@damien-renier-elastic
Update match-phrase-query.asciidoc (elastic#118828)
6726fc7 
(cherry picked from commit 8e9cccb)
@leemthompo leemthompo mentioned this pull request Jan 28, 2025
Merged
leemthompo pushed a commit to leemthompo/elasticsearch that referenced this pull request Jan 28, 2025
@damien-renier-elastic
Update match-phrase-query.asciidoc (elastic#118828)
dd1b99a 
(cherry picked from commit 8e9cccb)
leemthompo pushed a commit to leemthompo/elasticsearch that referenced this pull request Jan 28, 2025
@damien-renier-elastic
Update match-phrase-query.asciidoc (elastic#118828)
b5e0e45 
(cherry picked from commit 8e9cccb)
@leemthompo leemthompo mentioned this pull request Jan 28, 2025
Merged
@leemthompo
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ main
✅ 8.x
✅ 8.16

Questions ?

Please refer to the Backport tool documentation

elasticsearchmachine pushed a commit that referenced this pull request Jan 28, 2025
@leemthompo @damien-renier-elastic
Update match-phrase-query.asciidoc (#118828) (#121035)
80039d6 
(cherry picked from commit 8e9cccb)

Co-authored-by: Damien RENIER <[email protected]>
elasticsearchmachine pushed a commit that referenced this pull request Jan 28, 2025
@leemthompo @damien-renier-elastic
Update match-phrase-query.asciidoc (#118828) (#121034)
6e3592e 
(cherry picked from commit 8e9cccb)

Co-authored-by: Damien RENIER <[email protected]>
leemthompo added a commit that referenced this pull request Jan 28, 2025
@leemthompo @damien-renier-elastic
Update match-phrase-query.asciidoc (#118828) (#121033)
3939198 
(cherry picked from commit 8e9cccb)

Co-authored-by: Damien RENIER <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leemthompo leemthompo leemthompo approved these changes

Assignees

@leemthompo leemthompo

Labels
auto-backport Automatically create backport pull requests when merged >docs General docs changes external-contributor Pull request authored by a developer outside the Elasticsearch team Team:Docs Meta label for docs team v8.16.0 v8.17.2 v8.18.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@damien-renier-elastic @elasticsearchmachine @leemthompo