Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V_7 deprecation logging set to critical #118298

Merged
merged 7 commits into from
Dec 11, 2024
Merged

V_7 deprecation logging set to critical #118298

merged 7 commits into from
Dec 11, 2024

Conversation

JVerwolf
Copy link
Contributor

@JVerwolf JVerwolf commented Dec 9, 2024 •
edited
Loading

This PR changes all deprecation logging for V_7 to be “critical”.

@JVerwolf JVerwolf added :Core/Infra/REST API REST infrastructure and utilities >deprecation and removed v9.0.0 labels Dec 9, 2024
@JVerwolf JVerwolf changed the base branch from main to 8.x December 9, 2024 20:36
@elastic elastic deleted a comment from github-actions bot Dec 9, 2024
@JVerwolf JVerwolf marked this pull request as ready for review December 9, 2024 20:58
@JVerwolf JVerwolf requested a review from a team December 9, 2024 20:59
@elasticsearchmachine elasticsearchmachine added the Team:Core/Infra Meta label for core/infra team label Dec 9, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@JVerwolf JVerwolf added v8.17.1 and removed Team:Core/Infra Meta label for core/infra team labels Dec 9, 2024
@elasticsearchmachine elasticsearchmachine added the Team:Core/Infra Meta label for core/infra team label Dec 9, 2024
@elasticsearchmachine
Copy link
Collaborator

Hi @JVerwolf, I've created a changelog YAML for you. Note that since this PR is labelled >deprecation, you need to update the changelog YAML to fill out the extended information sections.

@JVerwolf JVerwolf added :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP :ml Machine learning and removed :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP :ml Machine learning labels Dec 9, 2024
ldematte
ldematte approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@ldematte ldematte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a changelog update, but otherwise LGTM

docs/changelog/118298.yaml Outdated Show resolved Hide resolved
@JVerwolf JVerwolf changed the title Enhancement/v7 critical deprecation logging V_7 deprecation logging set to critical Dec 11, 2024
@JVerwolf JVerwolf merged commit fcf634c into elastic:8.x Dec 11, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldematte ldematte ldematte approved these changes

Assignees
No one assigned
Labels
:Core/Infra/REST API REST infrastructure and utilities >deprecation Team:Core/Infra Meta label for core/infra team v8.17.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JVerwolf @elasticsearchmachine @ldematte