Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.17] Correct bit * byte and bit * float script comparisons (#117404) #117508

Merged

Conversation

benwtrent
Copy link
Member

Backport

This will backport the following commits from main to 8.17:

Questions ?

Please refer to the Backport tool documentation

I goofed on the bit * byte and bit * float comparisons. Naturally, these
should be bigendian and compare the dimensions with the binary ones
appropriately.

Additionally, I added a test to ensure that this is handled correctly.

(cherry picked from commit 374c88a)
Copy link
Contributor

Documentation preview:

@benwtrent benwtrent added auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Search Relevance/Vectors Vector search >bug labels Nov 25, 2024
@benwtrent
Copy link
Member Author

@elasticmachine update branch

@elasticmachine
Copy link
Collaborator

There are no new commits on the base branch.

@elasticsearchmachine elasticsearchmachine merged commit 0bc9af1 into elastic:8.17 Nov 25, 2024
16 checks passed
@benwtrent benwtrent deleted the backport/8.17/pr-117404 branch November 25, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport >bug :Search Relevance/Vectors Vector search v8.17.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants