Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move jsdoc tag at the end (otherwise it grabs all text) #3666

Merged
merged 2 commits into from
Jan 31, 2025

Conversation

swallez
Copy link
Member

@swallez swallez commented Jan 30, 2025

Fix the body's comment in MultiSearchTemplateRequest: the @codegen_name jsdoc tag was on the first line, which caused it to grab all following lines, which is not exactly what we want 😅

@swallez swallez requested a review from l-trotta January 30, 2025 18:16
@swallez swallez changed the title Move jdoc tag at the end (otherwise it grabs all text) Move jsdoc tag at the end (otherwise it grabs all text) Jan 30, 2025
Copy link
Contributor

Following you can find the validation results for the API you have changed.

API Status Request Response
msearch_template 🟢 1/1 1/1

You can validate this API yourself by using the make validate target.

Copy link
Contributor

Following you can find the validation results for the API you have changed.

API Status Request Response
msearch_template 🟢 1/1 1/1

You can validate this API yourself by using the make validate target.

@l-trotta l-trotta merged commit c9adece into main Jan 31, 2025
8 checks passed
@l-trotta l-trotta deleted the fix-template-request-codegen branch January 31, 2025 10:01
github-actions bot pushed a commit that referenced this pull request Jan 31, 2025
Co-authored-by: Laura Trotta <[email protected]>
(cherry picked from commit c9adece)
Copy link
Contributor

The backport to 8.17 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.17 8.17
# Navigate to the new working tree
cd .worktrees/backport-8.17
# Create a new branch
git switch --create backport-3666-to-8.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c9adece35c777c343d29ab3af14825e29f522c88
# Push it to GitHub
git push --set-upstream origin backport-3666-to-8.17
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.17

Then, create a pull request where the base branch is 8.17 and the compare/head branch is backport-3666-to-8.17.

l-trotta pushed a commit that referenced this pull request Jan 31, 2025
Co-authored-by: Laura Trotta <[email protected]>
(cherry picked from commit c9adece)

Co-authored-by: Sylvain Wallez <[email protected]>
l-trotta added a commit that referenced this pull request Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants