-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move jsdoc tag at the end (otherwise it grabs all text) #3666
Conversation
Following you can find the validation results for the API you have changed.
You can validate this API yourself by using the |
Following you can find the validation results for the API you have changed.
You can validate this API yourself by using the |
Co-authored-by: Laura Trotta <[email protected]> (cherry picked from commit c9adece)
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.17 8.17
# Navigate to the new working tree
cd .worktrees/backport-8.17
# Create a new branch
git switch --create backport-3666-to-8.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c9adece35c777c343d29ab3af14825e29f522c88
# Push it to GitHub
git push --set-upstream origin backport-3666-to-8.17
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.17 Then, create a pull request where the |
Co-authored-by: Laura Trotta <[email protected]> (cherry picked from commit c9adece) Co-authored-by: Sylvain Wallez <[email protected]>
Co-authored-by: Laura Trotta <[email protected]>
Fix the body's comment in
MultiSearchTemplateRequest
: the@codegen_name
jsdoc tag was on the first line, which caused it to grab all following lines, which is not exactly what we want 😅