Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Upsert documentation clarification #3591

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

[DOCS] Upsert documentation clarification #3591

wants to merge 2 commits into from

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Jan 24, 2025

This PR copies over updates made in elastic/elasticsearch#120684

Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
update 🟢 35/35 35/35

You can validate these APIs yourself by using the make validate target.

@leemthompo
Copy link
Contributor

You're too fast @lcawl! Might be a few tweaks on original but perhaps @thekofimensah could handle the updates? We mentioned previously that API docs updates need to prioritize working in the spec, rather than the old asciidoc docs.

Copy link

@kilfoyle kilfoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🐫

@lcawl
Copy link
Contributor Author

lcawl commented Jan 30, 2025

You're too fast @lcawl! Might be a few tweaks on original but perhaps @thekofimensah could handle the updates? We mentioned previously that API docs updates need to prioritize working in the spec, rather than the old asciidoc docs.

Sure! @thekofimensah if you want to contribute to this PR or replace it with another, lmk! Or if you want to chat about any of the processes related to this repo, I'm happy to chat too

@lcawl lcawl marked this pull request as draft January 30, 2025 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants