-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Watcher API examples #3489
Add Watcher API examples #3489
Conversation
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I left a few suggestions. Only nits, so please take or leave them.
specification/watcher/activate_watch/WatcherActivateWatchRequest.ts
Outdated
Show resolved
Hide resolved
specification/watcher/ack_watch/examples/response/WatcherAckWatchResponseExample1.yaml
Outdated
Show resolved
Hide resolved
specification/watcher/delete_watch/examples/response/DeleteWatchResponseExample1.yaml
Outdated
Show resolved
Hide resolved
specification/watcher/execute_watch/examples/response/WatcherExecuteWatchResponseExample1.yaml
Outdated
Show resolved
Hide resolved
specification/watcher/get_watch/examples/response/GetWatchResponseExample1.yaml
Outdated
Show resolved
Hide resolved
specification/watcher/stats/examples/response/WatcherStatsResponseExample1.yaml
Outdated
Show resolved
Hide resolved
specification/watcher/stats/examples/response/WatcherStatsResponseExample2.yaml
Outdated
Show resolved
Hide resolved
specification/watcher/stats/examples/response/WatcherStatsResponseExample3.yaml
Outdated
Show resolved
Hide resolved
…st.ts Co-authored-by: István Zoltán Szabó <[email protected]>
…tchResponseExample1.yaml Co-authored-by: István Zoltán Szabó <[email protected]>
…chResponseExample1.yaml Co-authored-by: István Zoltán Szabó <[email protected]>
…onseExample2.yaml Co-authored-by: István Zoltán Szabó <[email protected]>
…xecuteWatchResponseExample1.yaml Co-authored-by: István Zoltán Szabó <[email protected]>
…onseExample1.yaml Co-authored-by: István Zoltán Szabó <[email protected]>
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
5 similar comments
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
…onseExample3.yaml Co-authored-by: István Zoltán Szabó <[email protected]>
…onseExample1.yaml Co-authored-by: István Zoltán Szabó <[email protected]>
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
2 similar comments
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.x 8.x
# Navigate to the new working tree
cd .worktrees/backport-8.x
# Create a new branch
git switch --create backport-3489-to-8.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 2da56ac7163fff7ea11f8ee5b686858f2e3e883a
# Push it to GitHub
git push --set-upstream origin backport-3489-to-8.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.x Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.17 8.17
# Navigate to the new working tree
cd .worktrees/backport-8.17
# Create a new branch
git switch --create backport-3489-to-8.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 2da56ac7163fff7ea11f8ee5b686858f2e3e883a
# Push it to GitHub
git push --set-upstream origin backport-3489-to-8.17
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.17 Then, create a pull request where the |
Co-authored-by: István Zoltán Szabó <[email protected]> (cherry picked from commit 2da56ac)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
Co-authored-by: István Zoltán Szabó <[email protected]> (cherry picked from commit 2da56ac)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
Co-authored-by: István Zoltán Szabó <[email protected]> (cherry picked from commit 2da56ac)
Co-authored-by: István Zoltán Szabó <[email protected]> (cherry picked from commit 2da56ac)
Co-authored-by: István Zoltán Szabó <[email protected]> (cherry picked from commit 2da56ac)
Relates to #2482
This PR copies examples from https://www.elastic.co/guide/en/elasticsearch/reference/master/watcher-api.html
It also adds missing
doc_id
values and edits some descriptions.