-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert examples to yaml and add subfolders #3458
Conversation
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
1 similar comment
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, thank you for taking the time to rearrange everything :)
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
(cherry picked from commit b457ca0)
(cherry picked from commit b457ca0)
(cherry picked from commit b457ca0) Co-authored-by: Lisa Cawley <[email protected]>
(cherry picked from commit b457ca0) Co-authored-by: Lisa Cawley <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question, otherwise LGTM!
description: A successful response for getting status information for an async EQL search. | ||
# type: response | ||
# response_code: 200 | ||
value: >- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the only place in the value
field where >
is used as a separator instead of |
. I don't know if it's intentional or not, and I'm not even sure if it makes a difference at all, but I thought it might be worth pointing it out.
Relates to #2482
This PR moves existing example files to an "examples" subfolder.
It also converts existing example files from json to yaml so that we can comment out some of the content that's generating linting errors.