Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add examples to licensing APIs #3420

Merged
merged 12 commits into from
Jan 3, 2025
Merged

Add examples to licensing APIs #3420

merged 12 commits into from
Jan 3, 2025

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Jan 3, 2025

Copy link
Contributor

github-actions bot commented Jan 3, 2025

Following you can find the validation results for the APIs you have changed.

API Status Request Response
license.get_basic_status 🟢 3/3 3/3
license.get_trial_status 🟢 3/3 3/3
license.get 🟢 6/6 6/6
license.post_start_basic 🟢 5/5 5/5
license.post_start_trial 🟢 2/2 2/2
license.post 🟢 1/1 1/1

You can validate these APIs yourself by using the make validate target.

Copy link
Contributor

@szabosteve szabosteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested to add response codes, please take or leave them. LGTM, thanks!

@lcawl lcawl marked this pull request as ready for review January 3, 2025 15:46
Copy link
Contributor

github-actions bot commented Jan 3, 2025

Following you can find the validation results for the APIs you have changed.

API Status Request Response
license.get_basic_status 🟢 3/3 3/3
license.get_trial_status 🟢 3/3 3/3
license.get 🟢 6/6 6/6
license.post_start_basic 🟢 5/5 5/5
license.post_start_trial 🟢 2/2 2/2
license.post 🟢 1/1 1/1

You can validate these APIs yourself by using the make validate target.

@lcawl lcawl merged commit e153632 into main Jan 3, 2025
7 checks passed
@lcawl lcawl deleted the licensing-examples branch January 3, 2025 15:52
Copy link
Contributor

github-actions bot commented Jan 3, 2025

The backport to 8.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.x 8.x
# Navigate to the new working tree
cd .worktrees/backport-8.x
# Create a new branch
git switch --create backport-3420-to-8.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e153632213a73d955aa4f3119d5e9a55dc255b9d
# Push it to GitHub
git push --set-upstream origin backport-3420-to-8.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.x

Then, create a pull request where the base branch is 8.x and the compare/head branch is backport-3420-to-8.x.

Copy link
Contributor

github-actions bot commented Jan 3, 2025

The backport to 8.17 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.17 8.17
# Navigate to the new working tree
cd .worktrees/backport-8.17
# Create a new branch
git switch --create backport-3420-to-8.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e153632213a73d955aa4f3119d5e9a55dc255b9d
# Push it to GitHub
git push --set-upstream origin backport-3420-to-8.17
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.17

Then, create a pull request where the base branch is 8.17 and the compare/head branch is backport-3420-to-8.17.

lcawl added a commit that referenced this pull request Jan 3, 2025
Co-authored-by: István Zoltán Szabó <[email protected]>
(cherry picked from commit e153632)
@lcawl
Copy link
Contributor Author

lcawl commented Jan 3, 2025

💚 All backports created successfully

Status Branch Result
8.x

Questions ?

Please refer to the Backport tool documentation

lcawl added a commit that referenced this pull request Jan 3, 2025
Co-authored-by: István Zoltán Szabó <[email protected]>
(cherry picked from commit e153632)
@lcawl
Copy link
Contributor Author

lcawl commented Jan 3, 2025

💚 All backports created successfully

Status Branch Result
8.17

Questions ?

Please refer to the Backport tool documentation

lcawl added a commit that referenced this pull request Jan 3, 2025
Co-authored-by: István Zoltán Szabó <[email protected]>
(cherry picked from commit e153632)
lcawl added a commit that referenced this pull request Jan 3, 2025
Co-authored-by: István Zoltán Szabó <[email protected]>
(cherry picked from commit e153632)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants