Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add security.bulk_update_api_keys and security.delegate_pki #3402

Merged
merged 13 commits into from
Jan 8, 2025

Conversation

Copy link
Contributor

github-actions bot commented Jan 1, 2025

Following you can find the validation results for the APIs you have changed.

API Status Request Response
security.bulk_update_api_keys 🔴 4/4 3/4

You can validate these APIs yourself by using the make validate target.

@lcawl lcawl marked this pull request as ready for review January 1, 2025 08:12
Copy link
Contributor

github-actions bot commented Jan 2, 2025

Following you can find the validation results for the APIs you have changed.

API Status Request Response
security.bulk_update_api_keys 🔴 4/4 3/4

You can validate these APIs yourself by using the make validate target.

@lcawl lcawl changed the title Add security.bulk_update_api_keys Add security.bulk_update_api_keys and security.delegate_pki Jan 2, 2025
Copy link
Contributor

github-actions bot commented Jan 2, 2025

Following you can find the validation results for the APIs you have changed.

API Status Request Response
security.bulk_update_api_keys 🔴 4/4 3/4
security.delegate_pki Missing test Missing test

You can validate these APIs yourself by using the make validate target.

1 similar comment
Copy link
Contributor

github-actions bot commented Jan 3, 2025

Following you can find the validation results for the APIs you have changed.

API Status Request Response
security.bulk_update_api_keys 🔴 4/4 3/4
security.delegate_pki Missing test Missing test

You can validate these APIs yourself by using the make validate target.

@l-trotta l-trotta self-assigned this Jan 7, 2025
@l-trotta l-trotta force-pushed the api-key-bulk-update branch from 8385722 to f6648a4 Compare January 7, 2025 14:10
Copy link
Contributor

github-actions bot commented Jan 7, 2025

Following you can find the validation results for the APIs you have changed.

API Status Request Response
security.bulk_update_api_keys 🔴 4/4 3/4
security.delegate_pki Missing test Missing test

You can validate these APIs yourself by using the make validate target.

@l-trotta l-trotta force-pushed the api-key-bulk-update branch from f6648a4 to 0f497a6 Compare January 7, 2025 14:14
Copy link
Contributor

github-actions bot commented Jan 7, 2025

Following you can find the validation results for the APIs you have changed.

API Status Request Response
security.bulk_update_api_keys 🔴 4/4 3/4
security.delegate_pki Missing test Missing test

You can validate these APIs yourself by using the make validate target.

Copy link
Contributor

github-actions bot commented Jan 7, 2025

Following you can find the validation results for the APIs you have changed.

API Status Request Response
security.bulk_update_api_keys 🔴 4/4 3/4
security.delegate_pki Missing test Missing test

You can validate these APIs yourself by using the make validate target.

@l-trotta
Copy link
Contributor

l-trotta commented Jan 7, 2025

the delegate pki response is missing the authentication field, which is this veeeeery long class that seems to be missing from the spec. currently trying to understand if it can be added while removing some duplicates, will update

Copy link
Contributor

github-actions bot commented Jan 7, 2025

Following you can find the validation results for the APIs you have changed.

API Status Request Response
security.bulk_update_api_keys 🔴 4/4 3/4
security.delegate_pki Missing test Missing test

You can validate these APIs yourself by using the make validate target.

Copy link
Contributor

github-actions bot commented Jan 7, 2025

Following you can find the validation results for the APIs you have changed.

API Status Request Response
security.bulk_update_api_keys 🟢 4/4 4/4
security.delegate_pki Missing test Missing test

You can validate these APIs yourself by using the make validate target.

Copy link
Contributor

github-actions bot commented Jan 7, 2025

Following you can find the validation results for the APIs you have changed.

API Status Request Response
security.bulk_update_api_keys 🟢 4/4 4/4
security.delegate_pki Missing test Missing test

You can validate these APIs yourself by using the make validate target.

Copy link
Contributor

github-actions bot commented Jan 7, 2025

Following you can find the validation results for the APIs you have changed.

API Status Request Response
security.bulk_update_api_keys 🟢 4/4 4/4
security.delegate_pki Missing test Missing test

You can validate these APIs yourself by using the make validate target.

Copy link
Contributor

github-actions bot commented Jan 7, 2025

Following you can find the validation results for the APIs you have changed.

API Status Request Response
security.bulk_update_api_keys 🟢 4/4 4/4
security.delegate_pki Missing test Missing test

You can validate these APIs yourself by using the make validate target.

Copy link
Contributor

github-actions bot commented Jan 8, 2025

Following you can find the validation results for the APIs you have changed.

API Status Request Response
security.bulk_update_api_keys 🟢 4/4 4/4
security.delegate_pki Missing test Missing test

You can validate these APIs yourself by using the make validate target.

@l-trotta l-trotta merged commit a91c810 into main Jan 8, 2025
8 checks passed
@l-trotta l-trotta deleted the api-key-bulk-update branch January 8, 2025 14:51
github-actions bot pushed a commit that referenced this pull request Jan 8, 2025
* Add security.bulk_update_api_keys

* Add security.delegate_pki

* Add examples

* Add body to security.delegate_pki

* Add doc_id

* examples in subfolder

* Update specification/security/bulk_update_api_keys/SecurityBulkUpdateApiKeysRequest.ts

Co-authored-by: Laura Trotta <[email protected]>

* Update specification/security/bulk_update_api_keys/SecurityBulkUpdateApiKeysResponse.ts

Co-authored-by: Laura Trotta <[email protected]>

* Update specification/security/bulk_update_api_keys/SecurityBulkUpdateApiKeysResponse.ts

Co-authored-by: Laura Trotta <[email protected]>

* Update specification/security/delegate_pki/SecurityDelegatePkiResponse.ts

Co-authored-by: Laura Trotta <[email protected]>

* Fix style

* added authentication field to delegate pki res

---------

Co-authored-by: Laura Trotta <[email protected]>
Co-authored-by: Laura Trotta <[email protected]>
(cherry picked from commit a91c810)
github-actions bot pushed a commit that referenced this pull request Jan 8, 2025
* Add security.bulk_update_api_keys

* Add security.delegate_pki

* Add examples

* Add body to security.delegate_pki

* Add doc_id

* examples in subfolder

* Update specification/security/bulk_update_api_keys/SecurityBulkUpdateApiKeysRequest.ts

Co-authored-by: Laura Trotta <[email protected]>

* Update specification/security/bulk_update_api_keys/SecurityBulkUpdateApiKeysResponse.ts

Co-authored-by: Laura Trotta <[email protected]>

* Update specification/security/bulk_update_api_keys/SecurityBulkUpdateApiKeysResponse.ts

Co-authored-by: Laura Trotta <[email protected]>

* Update specification/security/delegate_pki/SecurityDelegatePkiResponse.ts

Co-authored-by: Laura Trotta <[email protected]>

* Fix style

* added authentication field to delegate pki res

---------

Co-authored-by: Laura Trotta <[email protected]>
Co-authored-by: Laura Trotta <[email protected]>
(cherry picked from commit a91c810)
l-trotta pushed a commit that referenced this pull request Jan 8, 2025
…3466)

* Add security.bulk_update_api_keys

* Add security.delegate_pki

* Add examples

* Add body to security.delegate_pki

* Add doc_id

* examples in subfolder

* Update specification/security/bulk_update_api_keys/SecurityBulkUpdateApiKeysRequest.ts

Co-authored-by: Laura Trotta <[email protected]>

* Update specification/security/bulk_update_api_keys/SecurityBulkUpdateApiKeysResponse.ts

Co-authored-by: Laura Trotta <[email protected]>

* Update specification/security/bulk_update_api_keys/SecurityBulkUpdateApiKeysResponse.ts

Co-authored-by: Laura Trotta <[email protected]>

* Update specification/security/delegate_pki/SecurityDelegatePkiResponse.ts

Co-authored-by: Laura Trotta <[email protected]>

* Fix style

* added authentication field to delegate pki res

---------

Co-authored-by: Laura Trotta <[email protected]>
Co-authored-by: Laura Trotta <[email protected]>
(cherry picked from commit a91c810)

Co-authored-by: Lisa Cawley <[email protected]>
l-trotta pushed a commit that referenced this pull request Jan 8, 2025
…3465)

* Add security.bulk_update_api_keys

* Add security.delegate_pki

* Add examples

* Add body to security.delegate_pki

* Add doc_id

* examples in subfolder

* Update specification/security/bulk_update_api_keys/SecurityBulkUpdateApiKeysRequest.ts

Co-authored-by: Laura Trotta <[email protected]>

* Update specification/security/bulk_update_api_keys/SecurityBulkUpdateApiKeysResponse.ts

Co-authored-by: Laura Trotta <[email protected]>

* Update specification/security/bulk_update_api_keys/SecurityBulkUpdateApiKeysResponse.ts

Co-authored-by: Laura Trotta <[email protected]>

* Update specification/security/delegate_pki/SecurityDelegatePkiResponse.ts

Co-authored-by: Laura Trotta <[email protected]>

* Fix style

* added authentication field to delegate pki res

---------

Co-authored-by: Laura Trotta <[email protected]>
Co-authored-by: Laura Trotta <[email protected]>
(cherry picked from commit a91c810)

Co-authored-by: Lisa Cawley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants