Add esql.async_query, esql.async_query_get, esql.async_query_delete #3398
Conversation
|
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
|
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
lcawl
changed the title
|
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
|
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
1 similar comment
|
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
| * To avoid any attempts of hacking or code injection, extract the values in a separate list of parameters. Use question mark placeholders (?) in the query string for each of the parameters. | ||
| * @doc_id esql-query-params | ||
| */ | ||
| params?: Array<FieldValue> |
There was a problem hiding this comment.
@l-trotta @swallez @Anaethelion Did we decide how to proceed with this field yet or was there any action from the ESQL server team?
For explanation: This definition is incorrect as ESQL accepts both, positional and named parameters. Currently, the API is a bit weird in the matter that it requires an array of single key dictionaries for the named parameters. This makes it hard to disambiguate which is why we proposed to soft-deprecate that syntax and have all named arguments in a single dictionary that replaces the array.
There was a problem hiding this comment.
Related: elastic/elasticsearch#118168
|
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.17 8.17
# Navigate to the new working tree
cd .worktrees/backport-8.17
# Create a new branch
git switch --create backport-3398-to-8.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 82aed1fdbdffc4243845d5f70e3223981b35140a
# Push it to GitHub
git push --set-upstream origin backport-3398-to-8.17
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.17Then, create a pull request where the |
…3398) (#3541) (cherry picked from commit 82aed1f) Co-authored-by: Lisa Cawley <[email protected]>
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
Relates to #3377, elastic/elasticsearch#119472
This PR adds three missing specifications based on https://www.elastic.co/guide/en/elasticsearch/reference/master/esql-async-query-api.html, https://www.elastic.co/guide/en/elasticsearch/reference/master/esql-async-query-get-api.html, and https://www.elastic.co/guide/en/elasticsearch/reference/master/esql-async-query-delete-api.html