[8.x] Add allow_partial_search_results and shard_failures to EQL (#3342) #3358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luigidellaquila
commented
Dec 18, 2024
output/schema/schema-serverless.json
Outdated
| @@ -3980,9 +3980,17 @@ | |||
| "stability": "stable" | |||
| } | |||
| }, | |||
| "description": "Create or update an index template.\nIndex templates define settings, mappings, and aliases that can be applied automatically to new indices.", | |||
| "description": "Create or update an index template.\nIndex templates define settings, mappings, and aliases that can be applied automatically to new indices.\nElasticsearch applies templates to new indices based on an index pattern that matches the index name.\n\nIMPORTANT: This documentation is about legacy index templates, which are deprecated and will be replaced by the composable templates introduced in Elasticsearch 7.8.\n\nComposable templates always take precedence over legacy templates.\nIf no composable template matches a new index, matching legacy templates are applied according to their order.\n\nIndex templates are only applied during index creation.\nChanges to index templates do not affect existing indices.\nSettings and mappings specified in create index API requests override any settings or mappings specified in an index template.", | |||
There was a problem hiding this comment.
This is completely unrelated, it was generated by make contrib (I ran it to resolve conflicts...).
Should it be reverted?
|
Following you can find the validation results for the API you have changed.
You can validate this API yourself by using the |
luigidellaquila
commented
Dec 18, 2024
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "name": "elasticsearch-specification", | |||
| "name": "backport-8.x", | |||
There was a problem hiding this comment.
Same here, maybe this just has to be reverted?
|
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
(cherry picked from commit 5987f79)
pquentin
force-pushed
the
backport-3342-to-8.x
branch
from
3cdf4a5 to
4def748
Compare
pquentin
changed the title
|
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 5987f79)