Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Edit text structure summaries #3344

Merged
merged 2 commits into from
Dec 18, 2024
Merged

[DOCS] Edit text structure summaries #3344

merged 2 commits into from
Dec 18, 2024

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Dec 17, 2024

Relates to #3226

This PR edits the text structure APIs https://www.elastic.co/docs/api/doc/elasticsearch/group/endpoint-text_structure based on https://www.elastic.co/guide/en/elasticsearch/reference/master/text-structure-apis.html.

NOTE: There are two APIs in the old docs that don't exist in the specifications, so they will also need to be edited once that work is complete.

Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
text_structure.find_structure 🟢 2/2 2/2
text_structure.test_grok_pattern 🟢 2/2 2/2

You can validate these APIs yourself by using the make validate target.

Copy link

@kilfoyle kilfoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🫏

@lcawl lcawl merged commit 14ddb71 into main Dec 18, 2024
11 checks passed
@lcawl lcawl deleted the text-structure-summaries branch December 18, 2024 00:17
github-actions bot pushed a commit that referenced this pull request Dec 18, 2024
github-actions bot pushed a commit that referenced this pull request Dec 18, 2024
lcawl added a commit that referenced this pull request Dec 18, 2024
(cherry picked from commit 14ddb71)

Co-authored-by: Lisa Cawley <[email protected]>
lcawl added a commit that referenced this pull request Dec 19, 2024
(cherry picked from commit 14ddb71)

Co-authored-by: Lisa Cawley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants