Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark query roles API public in Serverless #3316

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

slobodanadamovic
Copy link
Contributor

Marks Query Role API as public in Serverless and generates related specification.

Relates to elastic/elasticsearch#118798

Copy link
Contributor

Following you can find the validation results for the API you have changed.

API Status Request Response
security.query_role 🟢 2/2 2/2

You can validate this API yourself by using the make validate target.

Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM. We should merge this when the Elasticsearch has been fully deployed to Serverless.

Copy link
Contributor

Following you can find the validation results for the API you have changed.

API Status Request Response
security.query_role 🟢 2/2 2/2

You can validate this API yourself by using the make validate target.

@slobodanadamovic
Copy link
Contributor Author

Thanks! LGTM. We should merge this when the Elasticsearch has been fully deployed to Serverless.

👍 Thanks! Will keep it open util elastic/elasticsearch#118798 gets promoted.

@slobodanadamovic slobodanadamovic merged commit a058534 into main Jan 9, 2025
7 checks passed
@slobodanadamovic slobodanadamovic deleted the sa-mark-query-roles-api-public-serverless branch January 9, 2025 14:50
slobodanadamovic added a commit that referenced this pull request Jan 9, 2025
@slobodanadamovic
Copy link
Contributor Author

slobodanadamovic commented Jan 9, 2025

Revert was not my intention here. I wanted to delete a branch, but that happened automatically and instead it showed revert button 🤕

Edit: I see it only created a new branch revert-3316-sa-mark-query-roles-api-public-serverless. I will delete it now.

@slobodanadamovic slobodanadamovic restored the sa-mark-query-roles-api-public-serverless branch January 9, 2025 14:53
@slobodanadamovic slobodanadamovic deleted the sa-mark-query-roles-api-public-serverless branch January 9, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants