Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Edit node lifecycle summaries #3309

Merged
merged 3 commits into from
Dec 17, 2024
Merged

[DOCS] Edit node lifecycle summaries #3309

merged 3 commits into from
Dec 17, 2024

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Dec 14, 2024

Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
shutdown.delete_node Missing test Missing test
shutdown.get_node Missing test Missing test
shutdown.put_node Missing test Missing test

You can validate these APIs yourself by using the make validate target.

Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
shutdown.delete_node Missing test Missing test
shutdown.get_node Missing test Missing test
shutdown.put_node Missing test Missing test

You can validate these APIs yourself by using the make validate target.

Copy link
Contributor

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lcawl lcawl merged commit 0a8b60a into main Dec 17, 2024
7 checks passed
@lcawl lcawl deleted the node-summaries branch December 17, 2024 01:17
github-actions bot pushed a commit that referenced this pull request Dec 17, 2024
github-actions bot pushed a commit that referenced this pull request Dec 17, 2024
lcawl added a commit that referenced this pull request Dec 17, 2024
(cherry picked from commit 0a8b60a)

Co-authored-by: Lisa Cawley <[email protected]>
lcawl added a commit that referenced this pull request Dec 19, 2024
(cherry picked from commit 0a8b60a)

Co-authored-by: Lisa Cawley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants