Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rest-api-spec main #3019

Merged
merged 2 commits into from
Nov 15, 2024
Merged

Update rest-api-spec main #3019

merged 2 commits into from
Nov 15, 2024

Conversation

github-actions[bot]
Copy link
Contributor

As titled.

@github-actions github-actions bot requested a review from a team as a code owner October 15, 2024 04:06
@pquentin pquentin closed this Oct 15, 2024
@pquentin pquentin reopened this Oct 15, 2024
pquentin
pquentin reviewed Oct 15, 2024
View reviewed changes
specification/_json_spec/ingest.delete_ip_location_database.json
@@ -0,0 +1,28 @@
{
"ingest.delete_ip_location_database": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joegallo I'm slightly confused by those new APIs. Based on https://github.com/elastic/elasticsearch/pull/114548/files#diff-e691792ba34345b9c60eac06a6730438c8265376839f01e598b4f02e39f8a1ac, my understanding is that right now they are strictly equivalent to the GeoIP APIs. Will they do something different at some point? When should we expose them to clients and serverless docs?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the eventual future, the geoip APIs will be deprecated and removed (there is no plan to do this at the moment, but given the fullness of time it will happen 'one day'), but the ip_location APIs will stay around forever. In the near and intermediate term, it's the same behavior available under two names.

@github-actions github-actions bot force-pushed the automated/rest-api-spec-update-main branch from b7bdb35 to 182c797 Compare October 16, 2024 04:06
@github-actions github-actions bot requested a review from pquentin October 16, 2024 04:06
@github-actions github-actions bot force-pushed the automated/rest-api-spec-update-main branch 5 times, most recently from ce56dba to b9b56de Compare October 23, 2024 04:06
@github-actions github-actions bot force-pushed the automated/rest-api-spec-update-main branch 3 times, most recently from b298565 to 9fc89b2 Compare October 26, 2024 04:06
@github-actions github-actions bot force-pushed the automated/rest-api-spec-update-main branch 2 times, most recently from 4dab274 to ba87630 Compare November 2, 2024 04:06
@github-actions github-actions bot force-pushed the automated/rest-api-spec-update-main branch 4 times, most recently from a696c78 to d18df5a Compare November 8, 2024 04:06
This was referenced Nov 8, 2024
Merged
Merged
Merged
@github-actions github-actions bot force-pushed the automated/rest-api-spec-update-main branch 4 times, most recently from ae11786 to 3c47e90 Compare November 14, 2024 04:06
@github-actions github-actions bot force-pushed the automated/rest-api-spec-update-main branch from 3c47e90 to ac25b9d Compare November 15, 2024 04:08
pquentin
pquentin approved these changes Nov 15, 2024
View reviewed changes
Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging, we'll tackle the IP location API in #3107.

@pquentin pquentin merged commit 0dbfea3 into main Nov 15, 2024
9 checks passed
@pquentin pquentin deleted the automated/rest-api-spec-update-main branch November 15, 2024 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kderusso kderusso kderusso left review comments

@joegallo joegallo joegallo left review comments

@pquentin pquentin pquentin approved these changes

@Anaethelion Anaethelion Awaiting requested review from Anaethelion

@ezimuel ezimuel Awaiting requested review from ezimuel

@flobernd flobernd Awaiting requested review from flobernd

@JoshMock JoshMock Awaiting requested review from JoshMock

@l-trotta l-trotta Awaiting requested review from l-trotta

@miguelgrinberg miguelgrinberg Awaiting requested review from miguelgrinberg

@picandocodigo picandocodigo Awaiting requested review from picandocodigo

@srikanthmanvi srikanthmanvi Awaiting requested review from srikanthmanvi

@swallez swallez Awaiting requested review from swallez

@technige technige Awaiting requested review from technige

Assignees
No one assigned
Labels
compiler specification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pquentin @joegallo @kderusso