Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing default ML query descriptions #2917

Merged
merged 5 commits into from
Jan 8, 2025
Merged

Add missing default ML query descriptions #2917

merged 5 commits into from
Jan 8, 2025

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Sep 19, 2024

Per #2918, where the ML anomaly detection and data frame analytic jobs have an additional bit of info about default queries, that detail is lost since they're re-using the shared QueryContainer description. As a work-around for now I've moved that info into the API description.

@lcawl lcawl added the OpenAPI label Sep 19, 2024
@lcawl lcawl changed the title Add more x-abbreviated overlays in machine learning APIs Add x-abbreviated overlays in graph, script, async search, search, and ML APIs Sep 20, 2024
@lcawl lcawl marked this pull request as ready for review September 20, 2024 02:03
@lcawl lcawl requested a review from szabosteve September 20, 2024 02:03
@lcawl lcawl marked this pull request as draft September 20, 2024 05:22
Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
ml.put_data_frame_analytics 🔴 32/33 32/33
ml.put_datafeed 🔴 70/71 53/71
ml.put_job 🔴 219/227 223/225

You can validate these APIs yourself by using the make validate target.

2 similar comments
Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
ml.put_data_frame_analytics 🔴 32/33 32/33
ml.put_datafeed 🔴 70/71 53/71
ml.put_job 🔴 219/227 223/225

You can validate these APIs yourself by using the make validate target.

Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
ml.put_data_frame_analytics 🔴 32/33 32/33
ml.put_datafeed 🔴 70/71 53/71
ml.put_job 🔴 219/227 223/225

You can validate these APIs yourself by using the make validate target.

@lcawl lcawl changed the title Add x-abbreviated overlays in graph, script, async search, search, and ML APIs Add x-abbreviated overlay for QueryContainer; add missing default ML query descriptions Sep 20, 2024
@lcawl lcawl marked this pull request as ready for review September 20, 2024 19:37
@lcawl lcawl requested review from a team as code owners September 20, 2024 19:37
Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
ml.put_data_frame_analytics 🔴 32/33 32/33
ml.put_datafeed 🔴 70/71 53/71
ml.put_job 🔴 219/227 223/225

You can validate these APIs yourself by using the make validate target.

@lcawl lcawl marked this pull request as draft October 1, 2024 23:19
Copy link
Contributor

github-actions bot commented Oct 1, 2024

Following you can find the validation results for the APIs you have changed.

API Status Request Response
ml.put_data_frame_analytics 🔴 32/33 32/33
ml.put_datafeed 🔴 70/71 53/71
ml.put_job 🔴 219/227 223/225

You can validate these APIs yourself by using the make validate target.

Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
ml.put_data_frame_analytics 🔴 32/33 32/33
ml.put_datafeed 🔴 70/71 53/71
ml.put_job 🔴 219/227 223/225

You can validate these APIs yourself by using the make validate target.

1 similar comment
Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
ml.put_data_frame_analytics 🔴 32/33 32/33
ml.put_datafeed 🔴 70/71 53/71
ml.put_job 🔴 219/227 223/225

You can validate these APIs yourself by using the make validate target.

@lcawl lcawl changed the title Add x-abbreviated overlay for QueryContainer; add missing default ML query descriptions Add missing default ML query descriptions Oct 17, 2024
Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
ml.put_data_frame_analytics 🔴 32/33 32/33
ml.put_datafeed 🔴 70/71 53/71
ml.put_job 🔴 219/227 223/225

You can validate these APIs yourself by using the make validate target.

@lcawl lcawl marked this pull request as ready for review October 17, 2024 02:10
Copy link
Contributor

github-actions bot commented Jan 8, 2025

Following you can find the validation results for the APIs you have changed.

API Status Request Response
ml.put_data_frame_analytics 🟢 33/33 33/33
ml.put_datafeed 🔴 71/71 53/71
ml.put_job 🔴 227/227 223/225

You can validate these APIs yourself by using the make validate target.

@lcawl lcawl merged commit 7cf12f2 into main Jan 8, 2025
9 of 10 checks passed
@lcawl lcawl deleted the ml-overlays branch January 8, 2025 15:37
Copy link
Contributor

github-actions bot commented Jan 8, 2025

The backport to 8.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.x 8.x
# Navigate to the new working tree
cd .worktrees/backport-8.x
# Create a new branch
git switch --create backport-2917-to-8.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 7cf12f241b76c0c8ca3d864502c65eae5ab38389
# Push it to GitHub
git push --set-upstream origin backport-2917-to-8.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.x

Then, create a pull request where the base branch is 8.x and the compare/head branch is backport-2917-to-8.x.

Copy link
Contributor

github-actions bot commented Jan 8, 2025

The backport to 8.17 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.17 8.17
# Navigate to the new working tree
cd .worktrees/backport-8.17
# Create a new branch
git switch --create backport-2917-to-8.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 7cf12f241b76c0c8ca3d864502c65eae5ab38389
# Push it to GitHub
git push --set-upstream origin backport-2917-to-8.17
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.17

Then, create a pull request where the base branch is 8.17 and the compare/head branch is backport-2917-to-8.17.

lcawl added a commit that referenced this pull request Jan 8, 2025
@lcawl
Copy link
Contributor Author

lcawl commented Jan 8, 2025

💚 All backports created successfully

Status Branch Result
8.x

Questions ?

Please refer to the Backport tool documentation

@lcawl
Copy link
Contributor Author

lcawl commented Jan 8, 2025

💚 All backports created successfully

Status Branch Result
8.17

Questions ?

Please refer to the Backport tool documentation

lcawl added a commit that referenced this pull request Jan 8, 2025
lcawl added a commit that referenced this pull request Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants