-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds autoscaling and CCR API request and response examples #2788
Conversation
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
...oscaling/get_autoscaling_capacity/autoscalingApisGetAutoscalingCapacityResponseExample1.json
Outdated
Show resolved
Hide resolved
.../autoscaling/get_autoscaling_policy/autoscalingApisGetAutoscalingPolicyResponseExample1.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments, otherwise LGTM
@@ -0,0 +1,7 @@ | |||
{ | |||
"summary": "Creates an autoscaling policy named `my_autoscaling_policy` using the fixed autoscaling decider, applying to the set of nodes having (only) the `data_hot` role", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"summary": "Creates an autoscaling policy named
my_autoscaling_policy
using the fixed autoscaling decider, applying to the set of nodes having (only) thedata_hot
role",
... not a blocker but I think the summary ought to be shorter and this longer detail could move to the description.
...ccr/delete_auto_follow_pattern/ccrApisAutoFollowDeleteAutoFollowPatternResponseExample1.json
Outdated
Show resolved
Hide resolved
...n/ccr/pause_auto_follow_pattern/ccrApisAutoFollowPauseAutoFollowPatternResponseExample1.json
Outdated
Show resolved
Hide resolved
...ccr/resume_auto_follow_pattern/ccrApisAutoFollowResumeAutoFollowPatternResponseExample1.json
Outdated
Show resolved
Hide resolved
Co-authored-by: Lisa Cawley <[email protected]>
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
...n/autoscaling/put_autoscaling_policy/autoscalingApisPutAutoscalingPolicyRequestExample2.json
Outdated
Show resolved
Hide resolved
…isPutAutoscalingPolicyRequestExample2.json
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
Overview
Related to #2482.
This PR adds request and response examples to the autoscaling and CCR APIs.