Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds autoscaling and CCR API request and response examples #2788

Merged
merged 5 commits into from
Aug 22, 2024

Conversation

szabosteve
Copy link
Contributor

Overview

Related to #2482.
This PR adds request and response examples to the autoscaling and CCR APIs.

@szabosteve szabosteve requested a review from lcawl August 15, 2024 12:37
@szabosteve szabosteve changed the title Adds autoscaling and CCR API request and response examples. Adds autoscaling and CCR API request and response examples Aug 15, 2024
Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
autoscaling.delete_autoscaling_policy Missing test Missing test
autoscaling.get_autoscaling_capacity Missing test Missing test
autoscaling.get_autoscaling_policy Missing test Missing test
autoscaling.put_autoscaling_policy Missing test Missing test
ccr.delete_auto_follow_pattern Missing test Missing test
ccr.follow_info Missing test Missing test
ccr.follow_stats Missing test Missing test
ccr.follow Missing test Missing test
ccr.forget_follower Missing test Missing test
ccr.get_auto_follow_pattern Missing test Missing test
ccr.pause_auto_follow_pattern Missing test Missing test
ccr.pause_follow Missing test Missing test
ccr.put_auto_follow_pattern Missing test Missing test
ccr.resume_auto_follow_pattern Missing test Missing test
ccr.resume_follow Missing test Missing test
ccr.stats Missing test Missing test
ccr.unfollow Missing test Missing test

You can validate these APIs yourself by using the make validate target.

Copy link
Contributor

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, otherwise LGTM

@@ -0,0 +1,7 @@
{
"summary": "Creates an autoscaling policy named `my_autoscaling_policy` using the fixed autoscaling decider, applying to the set of nodes having (only) the `data_hot` role",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"summary": "Creates an autoscaling policy named my_autoscaling_policy using the fixed autoscaling decider, applying to the set of nodes having (only) the data_hot role",

... not a blocker but I think the summary ought to be shorter and this longer detail could move to the description.

Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
autoscaling.delete_autoscaling_policy Missing test Missing test
autoscaling.get_autoscaling_capacity Missing test Missing test
autoscaling.get_autoscaling_policy Missing test Missing test
autoscaling.put_autoscaling_policy Missing test Missing test
ccr.delete_auto_follow_pattern Missing test Missing test
ccr.follow_info Missing test Missing test
ccr.follow_stats Missing test Missing test
ccr.follow Missing test Missing test
ccr.forget_follower Missing test Missing test
ccr.get_auto_follow_pattern Missing test Missing test
ccr.pause_auto_follow_pattern Missing test Missing test
ccr.pause_follow Missing test Missing test
ccr.put_auto_follow_pattern Missing test Missing test
ccr.resume_auto_follow_pattern Missing test Missing test
ccr.resume_follow Missing test Missing test
ccr.stats Missing test Missing test
ccr.unfollow Missing test Missing test

You can validate these APIs yourself by using the make validate target.

Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
autoscaling.delete_autoscaling_policy Missing test Missing test
autoscaling.get_autoscaling_capacity Missing test Missing test
autoscaling.get_autoscaling_policy Missing test Missing test
autoscaling.put_autoscaling_policy Missing test Missing test
ccr.delete_auto_follow_pattern Missing test Missing test
ccr.follow_info Missing test Missing test
ccr.follow_stats Missing test Missing test
ccr.follow Missing test Missing test
ccr.forget_follower Missing test Missing test
ccr.get_auto_follow_pattern Missing test Missing test
ccr.pause_auto_follow_pattern Missing test Missing test
ccr.pause_follow Missing test Missing test
ccr.put_auto_follow_pattern Missing test Missing test
ccr.resume_auto_follow_pattern Missing test Missing test
ccr.resume_follow Missing test Missing test
ccr.stats Missing test Missing test
ccr.unfollow Missing test Missing test

You can validate these APIs yourself by using the make validate target.

@szabosteve szabosteve merged commit f1cadd9 into main Aug 22, 2024
6 checks passed
@szabosteve szabosteve deleted the szabosteve/api-examples-p2 branch August 22, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants