Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add transform API examples via overlay #2755

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Add transform API examples via overlay #2755

merged 1 commit into from
Aug 6, 2024

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Jul 31, 2024

Relates to #2482

This PR demonstrates a way we could short-term use overlays to insert examples into the openAPI document.

For now the updated OpenAPI document is generated by using the "make overlay-docs" command and it's stored in the output folder. Long-term we could potentially perform that processing as part of the OpenAPI generator or as part of the deployment process so that we didn't need to maintain otherwise identical files.

@lcawl lcawl changed the base branch from doc-examples to main August 2, 2024 18:51
@lcawl lcawl force-pushed the doc-example-overlays branch from b040f69 to 46eebe7 Compare August 2, 2024 18:58
@lcawl lcawl changed the title Add transform API via overlay Add transform API examples via overlay Aug 2, 2024
@lcawl lcawl marked this pull request as ready for review August 2, 2024 19:00
@lcawl lcawl requested a review from szabosteve August 2, 2024 19:00
Copy link
Contributor

@szabosteve szabosteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@lcawl lcawl merged commit 8e91c06 into main Aug 6, 2024
6 checks passed
@lcawl lcawl deleted the doc-example-overlays branch August 6, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants