Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non required field in connector config #2744

Merged
merged 1 commit into from
Jul 29, 2024
Merged

Non required field in connector config #2744

merged 1 commit into from
Jul 29, 2024

Conversation

l-trotta
Copy link
Contributor

As explained in the latest connector PR, some of the ConnectorConfig properties are only nullable to support an edge case which will be removed from the server. In the meantime though, this breaks the java client, so for now let's make them nullable.

Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
connector.check_in 🟢 3/3 3/3
connector.delete 🟢 9/9 9/9
connector.get 🔴 60/60 59/60
connector.last_sync 🟢 7/7 7/7
connector.list 🟢 19/19 19/19
connector.post 🟢 7/7 7/7
connector.put 🟢 13/13 13/13
connector.secret_delete 🟠 Missing type Missing type
connector.secret_get 🟠 Missing type Missing type
connector.secret_post 🟠 Missing type Missing type
connector.secret_put 🟠 Missing type Missing type
connector.sync_job_cancel 🟢 3/3 3/3
connector.sync_job_check_in 🟠 Missing type Missing type
connector.sync_job_claim 🟠 Missing type Missing type
connector.sync_job_delete 🟢 4/4 4/4
connector.sync_job_error 🟠 Missing type Missing type
connector.sync_job_get 🟢 22/22 22/22
connector.sync_job_list 🟢 12/12 12/12
connector.sync_job_post 🟢 50/50 50/50
connector.sync_job_update_stats 🟠 Missing type Missing type
connector.update_active_filtering 🟢 1/1 1/1
connector.update_api_key_id 🟢 4/4 4/4
connector.update_configuration 🔴 8/9 9/9
connector.update_error 🟢 4/4 4/4
connector.update_features 🟠 Missing type Missing type
connector.update_filtering_validation 🟢 3/3 3/3
connector.update_filtering 🟢 12/12 12/12
connector.update_index_name 🟢 4/4 4/4
connector.update_name 🟢 4/4 4/4
connector.update_native 🟢 3/3 3/3
connector.update_pipeline 🟢 3/3 3/3
connector.update_scheduling 🟢 3/3 3/3
connector.update_service_type 🟢 2/2 2/2
connector.update_status 🟢 3/3 3/3

You can validate these APIs yourself by using the make validate target.

@l-trotta l-trotta merged commit 7548143 into main Jul 29, 2024
7 checks passed
@l-trotta l-trotta deleted the quick-fix-connector branch July 29, 2024 15:23
github-actions bot pushed a commit that referenced this pull request Jul 29, 2024
l-trotta added a commit that referenced this pull request Jul 29, 2024
(cherry picked from commit 7548143)

Co-authored-by: Laura Trotta <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants