Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix eql.search response types #2663

Merged
merged 4 commits into from
Jul 1, 2024
Merged

Fix eql.search response types #2663

merged 4 commits into from
Jul 1, 2024

Conversation

pquentin
Copy link
Member

@pquentin pquentin commented Jul 1, 2024

Two changes were needed to pass validation:

Since PR validation is currently broken (see #2662), I validated those changes manually:

$ make validate api=eql.search type=response stack-version=8.15-SNAPSHOT
Validating endpoints                                                                                                                                          
Validating eql.search                                                          
eql.search response has been successfully validated!                                                                                                          
                                                                                                                                                              
✔ 32 out of 32 test response cases are passing.

I do not intend to merge this until PR validation passes.

Copy link
Contributor

github-actions bot commented Jul 1, 2024

Following you can find the validation results for the APIs you have changed.

API Status Request Response
eql.delete 🟢 3/3 3/3
eql.get_status 🟢 3/3 3/3
eql.get 🟢 3/3 3/3
eql.search 🟢 32/32 32/32

You can validate these APIs yourself by using the make validate target.

Copy link
Contributor

github-actions bot commented Jul 1, 2024

Following you can find the validation results for the APIs you have changed.

API Status Request Response
eql.delete 🟢 3/3 3/3
eql.get_status 🟢 3/3 3/3
eql.get 🟢 3/3 3/3
eql.search 🟢 32/32 32/32

You can validate these APIs yourself by using the make validate target.

@pquentin pquentin merged commit 10ce7ad into main Jul 1, 2024
6 checks passed
@pquentin pquentin deleted the eql-response branch July 1, 2024 07:51
Copy link
Contributor

github-actions bot commented Jul 1, 2024

The backport to 8.14 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.14 8.14
# Navigate to the new working tree
cd .worktrees/backport-8.14
# Create a new branch
git switch --create backport-2663-to-8.14
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 10ce7ade3851f86259a11f339be28c399b1def9c
# Push it to GitHub
git push --set-upstream origin backport-2663-to-8.14
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.14

Then, create a pull request where the base branch is 8.14 and the compare/head branch is backport-2663-to-8.14.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants