[ML] Update Delete Inference Endpoint for dry_run and force options #2602
Conversation
|
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
|
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
Co-authored-by: David Kyle <[email protected]>
|
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
|
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
|
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
|
|
||
| export class Response { | ||
| body: AcknowledgedResponseBase | ||
| body: { | ||
| dryRunResult: DeleteInferenceEndpointResult |
There was a problem hiding this comment.
What does dryRunResult mean here? Should it be body: DeleteInferenceEndpointResult ?
| * Acknowledged response. For dry_run, contains the list of ingest processors which reference the inference endpoint | ||
| */ | ||
| export class DeleteInferenceEndpointResult extends AcknowledgedResponseBase { | ||
| ingest_processors: Array<string> |
There was a problem hiding this comment.
I think the field is pipelines right? That's what I'm seeing in the response:
{
"acknowledged": false,
"pipelines": [
"elser"
]
}
|
|
||
| export class Response { | ||
| body: AcknowledgedResponseBase | ||
| body: { |
There was a problem hiding this comment.
Hmm I think this should be:
export class Response {
body: DeleteInferenceEndpointResult
}
I don't believe there's a dryRunResult field in the response.
|
Clearly I don't fully understand what the correspondence between the java code and the specification is. I'm going to do some reading and come back to this. |
|
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
Following on elastic/elasticsearch#109123 and elastic/elasticsearch#109384, this change updates the elasticsearch specification to include the dry_run and force options for the Delete Inference Endpoint API.