Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IndicesMappingLimitSettings #2588

Merged
merged 1 commit into from
May 29, 2024
Merged

Fix IndicesMappingLimitSettings #2588

merged 1 commit into from
May 29, 2024

Conversation

flobernd
Copy link
Member

The actual limits should accept `long` values instead of just `int`.
@flobernd flobernd force-pushed the fix-mapping-limit-settings branch from 7539945 to e32148d Compare May 29, 2024 08:27
Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
indices.add_block 🔴 1/2 1/2
indices.analyze 🔴 19/20 19/20
indices.clear_cache 🔴 3/4 3/4
indices.clone 🔴 4/5 4/5
indices.close 🔴 48/49 48/49
indices.create_data_stream 🔴 27/28 27/28
indices.create 🔴 877/896 895/896
indices.data_streams_stats 🔴 3/4 3/4
indices.delete_alias 🔴 14/15 4/15
indices.delete_data_lifecycle Missing test Missing test
indices.delete_data_stream 🔴 27/28 27/28
indices.delete_index_template 🔴 0/1 0/1
indices.delete_template 🔴 8/9 8/9
indices.delete 🔴 104/105 104/105
indices.disk_usage 🔴 4/5 4/5
indices.downsample 🔴 0/1 0/1
indices.exists_alias 🔴 35/36 35/36
indices.exists_index_template Missing test Missing test
indices.exists_template 🔴 14/15 14/15
indices.exists 🔴 38/39 38/39
indices.explain_data_lifecycle Missing test Missing test
indices.field_usage_stats 🔴 4/5 4/5
indices.flush 🔴 15/16 15/16
indices.forcemerge 🔴 6/7 5/7
indices.get_alias 🔴 82/83 70/83
indices.get_data_lifecycle Missing test Missing test
indices.get_data_stream 🔴 11/12 2/12
indices.get_field_mapping 🔴 14/15 13/15
indices.get_index_template 🔴 18/19 14/19
indices.get_mapping 🔴 92/93 90/93
indices.get_settings 🔴 55/56 53/56
indices.get_template 🔴 29/30 29/30
indices.get 🔴 52/53 52/53
indices.migrate_to_data_stream Missing test Missing test
indices.modify_data_stream Missing test Missing test
indices.open 🔴 17/18 17/18
indices.promote_data_stream Missing test Missing test
indices.put_alias 🔴 58/59 19/59
indices.put_data_lifecycle Missing test Missing test
indices.put_index_template 🔴 49/52 51/52
indices.put_mapping 🔴 72/76 75/76
indices.put_settings 🔴 53/57 56/57
indices.put_template 🔴 43/49 48/49
indices.recovery 🔴 8/9 8/9
indices.refresh 🔴 243/244 243/244
indices.reload_search_analyzers 🔴 1/2 1/2
indices.resolve_cluster 🔴 9/12 11/12
indices.resolve_index 🔴 5/6 5/6
indices.rollover 🔴 25/26 0/26
indices.segments 🔴 5/6 4/6
indices.shard_stores 🔴 4/5 3/5
indices.shrink 🔴 4/5 4/5
indices.simulate_index_template 🔴 5/7 4/7
indices.simulate_template 🔴 4/5 3/5
indices.split 🔴 10/11 10/11
indices.stats 🔴 102/103 30/102
indices.unfreeze 🔴 0/1 0/1
indices.update_aliases 🔴 25/26 6/26
indices.validate_query 🔴 6/7 6/7

You can validate these APIs yourself by using the make validate target.

@flobernd flobernd merged commit 3e71740 into main May 29, 2024
6 checks passed
@flobernd flobernd deleted the fix-mapping-limit-settings branch May 29, 2024 08:52
github-actions bot pushed a commit that referenced this pull request May 29, 2024
The actual limits should accept `long` values instead of just `int`.

(cherry picked from commit 3e71740)
flobernd added a commit that referenced this pull request May 29, 2024
The actual limits should accept `long` values instead of just `int`.

(cherry picked from commit 3e71740)

Co-authored-by: Florian Bernd <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants