Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deserialization for PutSynonymResponse #2573

Conversation

GeorgeCiachir
Copy link
Contributor

The ReloadResult should be a member of the PutResponseSynonym, instead of the ReloadDetails, so that the PutResponseSynonym is properly serialized.
Current behavior is that it throws a MissingRequiredPropertyException

This PR fixes elastic/elasticsearch-java#784

Copy link

❌ Author of the following commits did not sign a Contributor Agreement:
73d60cc

Please, read and sign the above mentioned agreement if you want to contribute to this project

@pquentin
Copy link
Member

pquentin commented May 24, 2024

Hello! Your commit does not have an email attached to it, as can be seen here: https://github.com/elastic/elasticsearch-specification/commit/73d60cc69eebf71eb97b34fdd29c2aa091cc16d3.patch. You can also see it with git show on the command line.

You should use the email address you used to sign the CLA instead. See https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-email-preferences/setting-your-commit-email-address#setting-your-commit-email-address-in-git for how to setup your email address in git. You will then need to edit your commit or create a new one, as you prefer.

@GeorgeCiachir GeorgeCiachir deleted the fix-deserialization-for-putsynonymresponse branch May 24, 2024 11:34
@GeorgeCiachir
Copy link
Contributor Author

Hi, @pquentin !

Thanks for the comment.
Didn't realize the issue. I created another PR, because I accidentally closed this one.
The new PR is: #2577

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PutSynonymResponse: Failed to decode response
2 participants