Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix whitespace in EQL links #2351

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Fix whitespace in EQL links #2351

merged 1 commit into from
Nov 21, 2023

Conversation

pquentin
Copy link
Member

The current links produce errors in the Python client documentation.

/.../elasticsearch-py/.nox/docs/lib/python3.11/site-packages/elasticsearch/client.py:docstring of elasticsearch.client.EqlClient.get:3: ERROR: Unknown t
arget name: "< https://www.elastic.co/guide/en/elasticsearch/reference/master/get-async-eql-search-api.html>".
/.../elasticsearch-py/.nox/docs/lib/python3.11/site-packages/elasticsearch/client.py:docstring of elasticsearch.client.EqlClient.get_status:4: ERROR: Un
known target name: "< https://www.elastic.co/guide/en/elasticsearch/reference/master/get-async-eql-status-api.html>".

@pquentin pquentin requested a review from szabosteve November 21, 2023 10:03
swallez
swallez approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@swallez swallez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pquentin pquentin merged commit f4d5312 into main Nov 21, 2023
6 checks passed
@pquentin pquentin deleted the fix-eql-links branch November 21, 2023 10:12
@github-actions github-actions bot mentioned this pull request Nov 21, 2023
Merged
github-actions bot pushed a commit that referenced this pull request Nov 21, 2023
@pquentin @github-actions
Fix whitespace in EQL links (#2351)
890e8de 
(cherry picked from commit f4d5312)
@github-actions github-actions bot mentioned this pull request Nov 21, 2023
Merged
github-actions bot pushed a commit that referenced this pull request Nov 21, 2023
@pquentin @github-actions
Fix whitespace in EQL links (#2351)
e41fc17 
(cherry picked from commit f4d5312)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swallez swallez swallez approved these changes

@szabosteve szabosteve Awaiting requested review from szabosteve

Assignees
No one assigned
Labels
backport 8.10 backport 8.11 specification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pquentin @swallez