Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing shard_min_doc_count to TermsAggregation #2175

Merged
merged 4 commits into from
Jun 20, 2024

Conversation

rand0m86
Copy link
Contributor

@rand0m86 rand0m86 commented Jul 10, 2023

Adding missing shard_min_doc_count field to terms aggregation.

Closes #2631

@rand0m86
Copy link
Contributor Author

rand0m86 commented Jul 10, 2023

Made it similar to elastic/elasticsearch-java#319.
@swallez Please take a look.

Ideally, I would like to get this new field in the java client, but I am not sure if this is enough.

@rand0m86
Copy link
Contributor Author

rand0m86 commented Aug 2, 2023

Pinging @Anaethelion, @davidkyle and @flobernd.
Guys, please take a look at this one.

Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked that this is the only bucket aggregation that's should have shard_min_doc_count but is missing it.

@rand0m86
Copy link
Contributor Author

Hi @pquentin, thanks for looking into this!
Can you let me know on the next steps? Like, when it will be merged, when should we expect it in the ES 8 client java library?

@pquentin pquentin merged commit 2bb4d0c into elastic:main Jun 20, 2024
12 of 13 checks passed
@l-trotta
Copy link
Contributor

@rand0m86 it will be in the next version, sorry for the long wait

Copy link
Contributor

The backport to 7.17 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-7.17 7.17
# Navigate to the new working tree
cd .worktrees/backport-7.17
# Create a new branch
git switch --create backport-2175-to-7.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 2bb4d0cc61ca56099a1dd4e1dee4bdb1bf7e4362
# Push it to GitHub
git push --set-upstream origin backport-2175-to-7.17
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-7.17

Then, create a pull request where the base branch is 7.17 and the compare/head branch is backport-2175-to-7.17.

github-actions bot pushed a commit that referenced this pull request Jun 20, 2024
Co-authored-by: Quentin Pradet <[email protected]>
(cherry picked from commit 2bb4d0c)
@rand0m86 rand0m86 deleted the patch-1 branch June 20, 2024 13:13
l-trotta pushed a commit that referenced this pull request Jun 20, 2024
Co-authored-by: Quentin Pradet <[email protected]>
(cherry picked from commit 2bb4d0c)

Co-authored-by: Vitalii Mahas <[email protected]>
@rand0m86
Copy link
Contributor Author

@rand0m86 it will be in the next version, sorry for the long wait

Cool, thanks for an update @l-trotta!

pquentin pushed a commit that referenced this pull request Jun 20, 2024
Co-authored-by: Quentin Pradet <[email protected]>
(cherry picked from commit 2bb4d0c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants