Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Sphinx index page #2373

Merged
merged 2 commits into from
Nov 14, 2023
Merged

Fix Sphinx index page #2373

merged 2 commits into from
Nov 14, 2023

Conversation

pquentin
Copy link
Member

It failed to provide an URL when instantiating the client, did not link to the Quickstart page and generally use older Python idioms.

It failed to provide an URL when instantiating the client, did not link
to the Quickstart page and generally use older Python idioms.
leemthompo
leemthompo previously approved these changes Nov 13, 2023
Copy link
Contributor

@leemthompo leemthompo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo my inexperience with reST formatting :)

docs/sphinx/index.rst Outdated Show resolved Hide resolved
@pquentin
Copy link
Member Author

You can see the result here: https://elasticsearch-py--2373.org.readthedocs.build/en/2373/

JoshMock
JoshMock previously approved these changes Nov 13, 2023
Co-authored-by: Liam Thompson <[email protected]>
@pquentin pquentin dismissed stale reviews from JoshMock and leemthompo via 439c120 November 14, 2023 02:33
@pquentin pquentin merged commit 8e7293f into elastic:main Nov 14, 2023
6 of 7 checks passed
@pquentin pquentin deleted the fix-sphinx-index branch November 14, 2023 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants