Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.11] Add Python 3.12 support #2370

Merged
merged 1 commit into from
Nov 9, 2023
Merged

[8.11] Add Python 3.12 support #2370

merged 1 commit into from
Nov 9, 2023

Conversation

pquentin
Copy link
Member

@pquentin pquentin commented Nov 8, 2023 •
edited
Loading

I accidentally pushed to main, but would be happy to get a review - I'll fix anything that was wrong here in main.

@pquentin pquentin requested a review from JoshMock November 8, 2023 13:57
JoshMock
JoshMock approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@JoshMock JoshMock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think you could have PRed to main and backported to 8.11, right?

@pquentin
Copy link
Member Author

pquentin commented Nov 9, 2023

LGTM. I think you could have PRed to main and backported to 8.11, right?

I could! But again I pushed a merge commit to main by accident and reverting would have been difficult.

@pquentin pquentin merged commit 2a4030c into elastic:8.11 Nov 9, 2023
7 checks passed
@pquentin pquentin deleted the 8.11-ci-3.12 branch November 9, 2023 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshMock JoshMock JoshMock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pquentin @JoshMock