fix examples.asciidoc to match implementation #2252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
💚 CLA has been signed |
Signed |
|
It looks like the linter failed on unrelated code, what is the suggestion to proceed here? |
Documentation mentions wrong / outdated keyword arguments when compared to the code implementation. These fixes correct the documentation to match the implementation. Closes elastic#2251
|
buildkite test this please |
pquentin
approved these changes
Nov 30, 2023
|
buildkite test this please |
github-actions bot
pushed a commit
that referenced
this pull request
Nov 30, 2023
* fix examples.asciidoc to match implementation Documentation mentions wrong / outdated keyword arguments when compared to the code implementation. These fixes correct the documentation to match the implementation. Closes #2251 * Fix interensting typo --------- Co-authored-by: Quentin Pradet <[email protected]> (cherry picked from commit ff2ef4d)
pquentin
pushed a commit
that referenced
this pull request
Dec 1, 2023
* fix examples.asciidoc to match implementation Documentation mentions wrong / outdated keyword arguments when compared to the code implementation. These fixes correct the documentation to match the implementation. Closes #2251 * Fix interensting typo --------- Co-authored-by: Quentin Pradet <[email protected]> (cherry picked from commit ff2ef4d) Co-authored-by: Mattias <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation mentions wrong / outdated keyword arguments when compared to the code implementation. These fixes correct the documentation to match the implementation.
Closes #2251